Skip to content

Commit 34b400e

Browse files
authored
chore!: Move try all navigators to experimental namespace (#5233)
These need a bit more work to make them work reliably on the user side. I propose to move the to the experimental namespace for now so the work does not need to be synchronized with major releases.
1 parent 06cbb5b commit 34b400e

File tree

2 files changed

+19
-16
lines changed

2 files changed

+19
-16
lines changed

Core/include/Acts/Propagator/TryAllNavigator.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#include <memory>
3131
#include <vector>
3232

33-
namespace Acts {
33+
namespace Acts::Experimental {
3434

3535
/// @brief Captures the common functionality of the try-all navigators
3636
///
@@ -939,4 +939,4 @@ class TryAllOverstepNavigator final : public TryAllNavigatorBase {
939939
}
940940
};
941941

942-
} // namespace Acts
942+
} // namespace Acts::Experimental

Tests/IntegrationTests/NavigatorConsistency.cpp

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -311,12 +311,13 @@ using StraightLinePropagator = Propagator<StraightLineStepper, Navigator>;
311311
using TestEigenStepper = EigenStepper<>;
312312
using EigenPropagator = Propagator<TestEigenStepper, Navigator>;
313313
using Reference1StraightLinePropagator =
314-
Propagator<StraightLineStepper, TryAllNavigator>;
315-
using Reference1EigenPropagator = Propagator<TestEigenStepper, TryAllNavigator>;
314+
Propagator<StraightLineStepper, Experimental::TryAllNavigator>;
315+
using Reference1EigenPropagator =
316+
Propagator<TestEigenStepper, Experimental::TryAllNavigator>;
316317
using Reference2StraightLinePropagator =
317-
Propagator<StraightLineStepper, TryAllOverstepNavigator>;
318+
Propagator<StraightLineStepper, Experimental::TryAllOverstepNavigator>;
318319
using Reference2EigenPropagator =
319-
Propagator<TestEigenStepper, TryAllOverstepNavigator>;
320+
Propagator<TestEigenStepper, Experimental::TryAllOverstepNavigator>;
320321

321322
StraightLineStepper slstepper;
322323
TestEigenStepper estepper(bField);
@@ -333,26 +334,28 @@ EigenPropagator epropagator(estepper,
333334

334335
Reference1StraightLinePropagator refslpropagator1(
335336
slstepper,
336-
TryAllNavigator({tGeometry, true, true, false},
337-
getDefaultLogger("ref1_sl_nav", Logging::INFO)),
337+
Experimental::TryAllNavigator({tGeometry, true, true, false},
338+
getDefaultLogger("ref1_sl_nav",
339+
Logging::INFO)),
338340
getDefaultLogger("ref1_sl_prop", Logging::INFO));
339341
Reference1EigenPropagator refepropagator1(
340342
estepper,
341-
TryAllNavigator({tGeometry, true, true, false,
342-
BoundaryTolerance::Infinite()},
343-
getDefaultLogger("ref1_e_nav", Logging::INFO)),
343+
Experimental::TryAllNavigator(
344+
{tGeometry, true, true, false, BoundaryTolerance::Infinite()},
345+
getDefaultLogger("ref1_e_nav", Logging::INFO)),
344346
getDefaultLogger("ref1_e_prop", Logging::INFO));
345347

346348
Reference2EigenPropagator refepropagator2(
347349
estepper,
348-
TryAllOverstepNavigator({tGeometry, true, true, false,
349-
BoundaryTolerance::Infinite()},
350-
getDefaultLogger("ref2_e_nav", Logging::INFO)),
350+
Experimental::TryAllOverstepNavigator(
351+
{tGeometry, true, true, false, BoundaryTolerance::Infinite()},
352+
getDefaultLogger("ref2_e_nav", Logging::INFO)),
351353
getDefaultLogger("ref2_e_prop", Logging::INFO));
352354
Reference2StraightLinePropagator refslpropagator2(
353355
slstepper,
354-
TryAllOverstepNavigator({tGeometry, true, true, false},
355-
getDefaultLogger("ref2_sl_nav", Logging::INFO)),
356+
Experimental::TryAllOverstepNavigator({tGeometry, true, true, false},
357+
getDefaultLogger("ref2_sl_nav",
358+
Logging::INFO)),
356359
getDefaultLogger("ref2_sl_prop", Logging::INFO));
357360

358361
auto eventGen =

0 commit comments

Comments
 (0)