Merge pull request #1183 from stephenswat/feat/post_fit_efficiency

Add post-finding track efficiency output

Author: stephenswat

examples/run/cuda/seeding_example_cuda.cpp

@@ -97,6 +97,13 @@ int seq_run(const traccc::opts::track_seeding& seeding_opts,
             .truth_config = truth_finding_opts,
             .track_truth_config = track_matching_opts},
         logger().clone("FindingPerformanceWriter"));
+    traccc::finding_performance_writer postfit_find_performance_writer(
+        traccc::finding_performance_writer::config{
+            .file_path = "performance_track_postfit_finding.root",
+            .truth_config = truth_finding_opts,
+            .track_truth_config = track_matching_opts,
+            .require_fit = true},
+        logger().clone("PostFitFindingPerformanceWriter"));
     traccc::fitting_performance_writer fit_performance_writer(
         traccc::fitting_performance_writer::config{},
         logger().clone("FittingPerformanceWriter"));
@@ -444,6 +451,11 @@ int seq_run(const traccc::opts::track_seeding& seeding_opts,
                     traccc::default_algebra>::const_data(track_candidates_cuda),
                 evt_data);
 
+            postfit_find_performance_writer.write(
+                traccc::edm::track_container<
+                    traccc::default_algebra>::const_data(track_states_cuda),
+                evt_data);
+
             for (unsigned int i = 0; i < track_states_cuda.tracks.size(); i++) {
                 host_detector_visitor<detector_type_list>(
                     host_det, [&]<typename detector_traits_t>(
@@ -461,6 +473,7 @@ int seq_run(const traccc::opts::track_seeding& seeding_opts,
         sd_performance_writer.finalize();
         nsd_performance_writer.finalize();
         find_performance_writer.finalize();
+        postfit_find_performance_writer.finalize();
         fit_performance_writer.finalize();
         std::cout << nsd_performance_writer.generate_report_str();
     }

performance/include/traccc/efficiency/finding_performance_writer.hpp

@@ -56,6 +56,8 @@ class finding_performance_writer : public messaging {
         truth_matching_config truth_config;
         track_matching_config track_truth_config;
 
+        bool require_fit = false;
+
         stat_plot_tool_config stat_config{};
     };
 

performance/src/efficiency/finding_performance_writer.cpp

@@ -12,6 +12,7 @@
 #include "duplication_plot_tool.hpp"
 #include "eff_plot_tool.hpp"
 #include "fake_tracks_plot_tool.hpp"
+#include "traccc/edm/track_fit_outcome.hpp"
 #include "traccc/utils/logging.hpp"
 #include "track_classification.hpp"
 
@@ -90,7 +91,8 @@ namespace {
  * with its corresponding measurements.
  */
 std::vector<std::vector<measurement>> prepare_data(
-    const edm::track_container<default_algebra>::const_view& track_view) {
+    const edm::track_container<default_algebra>::const_view& track_view,
+    bool require_fit = false) {
     std::vector<std::vector<measurement>> result;
 
     // Set up the input containers.
@@ -102,6 +104,10 @@ std::vector<std::vector<measurement>> prepare_data(
     result.reserve(n_tracks);
 
     for (unsigned int i = 0; i < n_tracks; i++) {
+        if (require_fit &&
+            tracks.tracks.at(i).fit_outcome() != track_fit_outcome::SUCCESS) {
+            continue;
+        }
         std::vector<measurement> result_measurements;
         for (const edm::track_constituent_link& link :
              tracks.tracks.constituent_links().at(i)) {
@@ -301,13 +307,18 @@ void finding_performance_writer::write(
 
     const unsigned int n_tracks = tracks.tracks.size();
     for (unsigned int i = 0; i < n_tracks; i++) {
+        if (m_cfg.require_fit &&
+            tracks.tracks.at(i).fit_outcome() != track_fit_outcome::SUCCESS) {
+            continue;
+        }
 
         // Fill stat plots
         m_data->m_stat_plot_tool.fill(m_data->m_stat_plot_cache,
                                       tracks.tracks.at(i));
     }
 
-    std::vector<std::vector<measurement>> prep_data = prepare_data(track_view);
+    std::vector<std::vector<measurement>> prep_data =
+        prepare_data(track_view, m_cfg.require_fit);
     write_common(prep_data, evt_data);
 }