Skip to content

Commit 993c352

Browse files
committed
Small changes in the host fitting code.
Based on the PR feedback.
1 parent b66f73f commit 993c352

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

core/include/traccc/fitting/details/kalman_fitting.hpp

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -87,23 +87,16 @@ typename edm::track_fit_container<algebra_t>::host kalman_fitting(
8787
auto result_tracks_view = vecmem::get_data(result.tracks);
8888
typename edm::track_fit_collection<algebra_t>::device
8989
result_tracks_device{result_tracks_view};
90-
typename edm::track_fit_collection<algebra_t>::device::proxy_type
91-
fitted_track_device =
92-
result_tracks_device.at(result_tracks_device.size() - 1);
93-
auto result_states_view = vecmem::get_data(result.states);
9490
typename fitter_t::state fitter_state(
95-
fitted_track_device,
91+
result_tracks_device.at(result_tracks_device.size() - 1),
9692
typename edm::track_state_collection<algebra_t>::device{
97-
result_states_view},
93+
vecmem::get_data(result.states)},
9894
measurements, seqs_buffer);
9995

100-
// Run the fitter.
101-
kalman_fitter_status fit_status =
102-
fitter.fit(track_candidates.params().at(i), fitter_state);
103-
104-
if (fit_status != kalman_fitter_status::SUCCESS) {
105-
// TODO: Print a warning here.
106-
}
96+
// Run the fitter. The status that it returns is not used here. The main
97+
// failure modes are saved onto the fitted track itself. Not sure what
98+
// we may want to do with the more detailed status codes in the future.
99+
(void)fitter.fit(track_candidates.params().at(i), fitter_state);
107100
}
108101

109102
// Return the fitted track states.

0 commit comments

Comments
 (0)