Merge pull request #1162 from stephenswat/build/acts_43_4

Update ACTS dependency to v43.3

Author: stephenswat

.github/workflows/builds.yml

@@ -129,7 +129,7 @@ jobs:
         run: ${GITHUB_WORKSPACE}/.github/find_f64_ptx.py --source ${GITHUB_WORKSPACE} --build build $(find build -name "*.ptx")
 
   macos:
-    runs-on: macos-14
+    runs-on: macos-15
     name: macOS-Release
     steps:
       - uses: actions/checkout@v4

core/CMakeLists.txt

@@ -134,7 +134,7 @@ traccc_add_library( traccc_core core TYPE SHARED
   "src/ambiguity_resolution/legacy/greedy_ambiguity_resolution_algorithm.cpp")
 target_link_libraries( traccc_core
   PUBLIC Eigen3::Eigen vecmem::core covfie::core detray::core detray::detectors
-         traccc::algebra ActsCore )
+         traccc::algebra Acts::Core )
 
 # Prevent Eigen from getting confused when building code for a
 # CUDA or HIP backend with SYCL.

extern/acts/CMakeLists.txt

@@ -12,8 +12,10 @@ include( FetchContent )
 message( STATUS "Building Acts as part of the TRACCC project" )
 
 # Declare where to get Acts from.
+# HACK: Go back to using a real Acts release when a version after
+# v43.3.0 is released that incorporates Acts#4659
 set( TRACCC_ACTS_SOURCE
-   "URL;https://github.com/acts-project/acts/archive/refs/tags/v39.0.0.tar.gz;URL_MD5;a50bf40cb5bc6b831d13ee1eb89b0c14"
+   "GIT_REPOSITORY;https://github.com/acts-project/acts.git;GIT_TAG;dfa5b4fd97d1cf9674f3c580e5fc4cd7f0c4103f"
    CACHE STRING "Source for Acts, when built as part of this project" )
 mark_as_advanced( TRACCC_ACTS_SOURCE )
 FetchContent_Declare( Acts SYSTEM ${TRACCC_ACTS_SOURCE} )

io/CMakeLists.txt

@@ -80,8 +80,8 @@ traccc_add_library( traccc_io io TYPE SHARED
   "src/obj/write_track_candidates.cpp"
   )
 target_link_libraries( traccc_io
-  PUBLIC vecmem::core traccc::core ActsCore dfelibs::dfelibs
-  PRIVATE detray::core detray::io ActsPluginJson )
+  PUBLIC vecmem::core traccc::core Acts::Core dfelibs::dfelibs
+  PRIVATE detray::core detray::io Acts::PluginJson )
 target_compile_definitions( traccc_io
   PRIVATE TRACCC_TEST_DATA_DIR="${CMAKE_SOURCE_DIR}/data" )
 if( OpenMP_CXX_FOUND )

tests/CMakeLists.txt

@@ -24,7 +24,7 @@ add_library( traccc_tests_common STATIC
 target_include_directories( traccc_tests_common
     PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/common )
 target_link_libraries( traccc_tests_common
-    PUBLIC dfelibs::dfelibs GTest::gtest ActsCore vecmem::core
+    PUBLIC dfelibs::dfelibs GTest::gtest Acts::Core vecmem::core
            detray::core detray::io detray::test_common covfie::core traccc::core traccc::io traccc_simulation)
 
 # Use ROOT in traccc_tests_common, if requested.

tests/cpu/compare_with_acts_seeding.cpp

@@ -387,10 +387,10 @@ TEST_P(CompareWithActsSeedingTests, Run) {
     // EXPECT_EQ(seeds.size(), seedVector.size());
     EXPECT_NEAR(static_cast<double>(traccc_seeds.size()),
                 static_cast<double>(n_matched_acts_seeds),
-                static_cast<double>(traccc_seeds.size()) * 0.0023);
+                static_cast<double>(traccc_seeds.size()) * 0.004);
     EXPECT_GT(static_cast<double>(n_matched_acts_seeds) /
                   static_cast<double>(traccc_seeds.size()),
-              0.9977);
+              0.995);
 }
 
 INSTANTIATE_TEST_SUITE_P(