Merge pull request #1091 from stephenswat/feat/seeding_max_z_cut

Add maximum Z distance cut in seeding

Author: stephenswat

core/include/traccc/seeding/detail/seeding_config.hpp

@@ -45,6 +45,9 @@ struct seedfinder_config {
     // maximum distance in mm in r between two measurements within one seed
     float deltaRMax = 80 * unit<float>::mm;
 
+    // maximum distance in mm in z between measurements in one seed
+    float deltaZMax = 450 * unit<float>::mm;
+
     // FIXME: this is not used yet
     //        float upperPtResolutionPerSeed = 20* Acts::GeV;
 

core/include/traccc/seeding/doublet_finding_helper.hpp

@@ -76,7 +76,8 @@ bool TRACCC_HOST_DEVICE doublet_finding_helper::isCompatible(
     if ((deltaR >= config.deltaRMax) || (deltaR <= config.deltaRMin) ||
         (math::fabs(cotTheta) >= config.cotThetaMax * deltaR) ||
         (zOrigin <= config.collisionRegionMin * deltaR) ||
-        (zOrigin >= config.collisionRegionMax * deltaR)) {
+        (zOrigin >= config.collisionRegionMax * deltaR) ||
+        std::abs(cotTheta) >= config.deltaZMax) {
         return false;
     }
 

tests/cpu/compare_with_acts_seeding.cpp

@@ -109,6 +109,7 @@ TEST_P(CompareWithActsSeedingTests, Run) {
     traccc_config.deltaRMin = 1.f * traccc::unit<float>::mm;
     traccc_config.deltaRMax = 60.f * traccc::unit<float>::mm;
     traccc_config.sigmaScattering = 1.0f;
+    traccc_config.deltaZMax = 1000000.f * traccc::unit<float>::mm;
 
     traccc::spacepoint_grid_config grid_config(traccc_config);