Skip to content

feat: device logging #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

feat: device logging #1179

merged 1 commit into from
Nov 7, 2025

Conversation

@niermann999
Copy link
Contributor

@niermann999 niermann999 commented Nov 5, 2025 •
edited
Loading

Add device and host-device logging functionality to parts of the code where the ACTS logger does not work. This will need a cleanup in the future

@niermann999 niermann999 force-pushed the feat-device-logging branch 2 times, most recently from 5a38f1a to 6a59196 Compare November 7, 2025 13:37
@niermann999 niermann999 added feature New feature or request high priority labels Nov 7, 2025
@stephenswat
Copy link
Member

stephenswat commented Nov 7, 2025

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

KernelReciprocal ThroughputParallelism
a5449ab6a59196Deltaa5449ab6a59196
propagate_to_next_surface8.44 ms8.48 ms0.5%3.383.38
fit_forward2.58 ms2.52 ms-2.2%6.136.12
fit_backward1.22 ms1.23 ms1.0%4.574.57
find_tracks1.22 ms1.20 ms-1.0%1.841.84
ccl_kernel832.31 μs830.87 μs-0.2%1.371.37
Thrust::sort708.44 μs708.12 μs-0.0%3.763.76
count_doublets621.69 μs628.85 μs1.2%1.611.61
count_triplets590.25 μs589.63 μs-0.1%1.021.02
find_doublets445.76 μs444.44 μs-0.3%3.083.08
find_triplets173.22 μs171.87 μs-0.8%1.311.31
select_seeds53.26 μs53.87 μs1.2%1.341.34
remove_duplicates27.33 μs27.22 μs-0.4%22.3922.47
populate_grid23.37 μs23.38 μs0.1%1.221.22
count_grid_capacities22.14 μs22.15 μs0.1%1.221.22
apply_interaction15.13 μs15.13 μs-0.0%6.516.51
update_triplet_weights14.98 μs15.07 μs0.6%1.271.27
estimate_track_params14.32 μs14.31 μs-0.1%2.152.15
fit_prelude13.78 μs13.78 μs-0.0%18.2618.27
form_spacepoints13.16 μs13.09 μs-0.5%1.481.48
fill_finding_propagation_sort_keys9.31 μs9.32 μs0.1%7.327.31
reduce_triplet_counts6.30 μs6.31 μs0.2%3.083.08
build_tracks5.02 μs4.97 μs-0.9%12.2712.28
unknown2.06 μs2.06 μs0.2%9.859.85
fill_finding_duplicate_removal_sort_keys1.85 μs1.86 μs0.3%32.7232.63
fill_fitting_sort_keys186.91 ns186.41 ns-0.3%18.3718.35
fill_prefix_sum171.90 ns171.93 ns0.0%341.30341.30
Total17.04 ms17.03 ms-0.1%3.553.55

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.4% Duplication on New Code

See analysis details on SonarQube Cloud

@niermann999 niermann999 merged commit a930d77 into acts-project:main Nov 7, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenswat stephenswat stephenswat approved these changes

Assignees

No one assigned

Labels

feature New feature or request high priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niermann999 @stephenswat