Skip to content

Commit 2285f85

Browse files
committed
Fix memory leak caused by re-creating render targets every frame
1 parent 3153d9c commit 2285f85

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/client/rendering/renderTargetHelper.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,9 @@ export function getNextValidTextureDimension (size) {
203203
// (in terms of 2^n, see getNextValidTextureDimension)
204204
// size for the domElement of the threeRenderer
205205
export function renderTargetHasRightSize (renderTarget, threeRenderer) {
206-
const screenW = threeRenderer.domElement.clientWidth
207-
const screenH = threeRenderer.domElement.clientHeight
206+
// Use .width/.height to match createRenderTarget (not clientWidth/clientHeight)
207+
const screenW = threeRenderer.domElement.width
208+
const screenH = threeRenderer.domElement.height
208209

209210
let targetTexWidth = getNextValidTextureDimension(screenW, _chooseBiggerSize)
210211
let targetTexHeight = getNextValidTextureDimension(screenH, _chooseBiggerSize)

0 commit comments

Comments
 (0)