add tests for url_search_params::set

Author: anonrig

include/ada/url_search_params-inl.h

@@ -21,9 +21,7 @@ inline void url_search_params::append(const std::string_view key,
   params.emplace_back(std::string(key), std::string(value));
 }
 
-inline size_t url_search_params::get_size() const noexcept {
-  return params.size();
-}
+inline size_t url_search_params::size() const noexcept { return params.size(); }
 
 inline std::optional<std::string_view> url_search_params::get(
     const std::string_view key) {

include/ada/url_search_params.h

@@ -16,14 +16,15 @@ namespace ada {
  * @see https://url.spec.whatwg.org/#interface-urlsearchparams
  */
 struct url_search_params {
+  // TODO: Add missing constructors
   url_search_params() = default;
   url_search_params(const url_search_params &u) = default;
   url_search_params(url_search_params &&u) noexcept = default;
   url_search_params &operator=(url_search_params &&u) noexcept = default;
   url_search_params &operator=(const url_search_params &u) = default;
   ~url_search_params() = default;
 
-  [[nodiscard]] inline size_t get_size() const noexcept;
+  [[nodiscard]] inline size_t size() const noexcept;
 
   /**
    * @see https://url.spec.whatwg.org/#dom-urlsearchparams-append
@@ -33,8 +34,8 @@ struct url_search_params {
   /**
    * @see https://url.spec.whatwg.org/#dom-urlsearchparams-delete
    */
-  inline void remove(std::string_view key);
-  inline void remove(std::string_view key, std::string_view value);
+  void remove(std::string_view key);
+  void remove(std::string_view key, std::string_view value);
 
   /**
    * @see https://url.spec.whatwg.org/#dom-urlsearchparams-get
@@ -54,20 +55,19 @@ struct url_search_params {
   /**
    * @see https://url.spec.whatwg.org/#dom-urlsearchparams-set
    */
-  inline void set(std::string_view key, std::string_view value);
+  void set(std::string_view key, std::string_view value);
 
   /**
    * @see https://url.spec.whatwg.org/#dom-urlsearchparams-sort
    */
-  inline void sort() const noexcept;
+  void sort() const noexcept;
 
   /**
    * @see https://url.spec.whatwg.org/#urlsearchparams-stringification-behavior
    */
   std::string to_string();
 
  private:
-  uint32_t size{0};
   std::vector<std::tuple<std::string, std::string>> params{};
 };  // url_search_params
 

src/url_search_params.cpp

@@ -8,15 +8,15 @@
 
 namespace ada {
 
-inline void url_search_params::remove(const std::string_view key) {
+void url_search_params::remove(const std::string_view key) {
   params.erase(
       std::remove_if(params.begin(), params.end(),
                      [&key](auto param) { return std::get<0>(param) == key; }),
       params.end());
 }
 
-inline void url_search_params::remove(const std::string_view key,
-                                      std::string_view value) {
+void url_search_params::remove(const std::string_view key,
+                               std::string_view value) {
   params.erase(std::remove_if(params.begin(), params.end(),
                               [&key, &value](auto param) {
                                 return std::get<0>(param) == key &&
@@ -25,12 +25,12 @@ inline void url_search_params::remove(const std::string_view key,
                params.end());
 }
 
-inline void url_search_params::sort() const noexcept {
+void url_search_params::sort() const noexcept {
   // TODO: Implement this
 }
 
-inline void url_search_params::set(const std::string_view key,
-                                   const std::string_view value) {
+void url_search_params::set(const std::string_view key,
+                            const std::string_view value) {
   params.erase(
       std::remove_if(params.begin(), params.end(),
                      [&key](auto param) { return std::get<0>(param) == key; }),

tests/url_search_params.cpp

@@ -4,10 +4,10 @@
 TEST(url_search_params, append) {
   auto search_params = ada::url_search_params();
   search_params.append("key", "value");
-  ASSERT_EQ(search_params.get_size(), 1);
+  ASSERT_EQ(search_params.size(), 1);
   ASSERT_TRUE(search_params.has("key"));
   search_params.append("key", "value2");
-  ASSERT_EQ(search_params.get_size(), 2);
+  ASSERT_EQ(search_params.size(), 2);
   ASSERT_EQ(search_params.get_all("key").size(), 2);
   SUCCEED();
 }
@@ -16,7 +16,18 @@ TEST(url_search_params, to_string) {
   auto search_params = ada::url_search_params();
   search_params.append("key1", "value1");
   search_params.append("key2", "value2");
-  ASSERT_EQ(search_params.get_size(), 2);
+  ASSERT_EQ(search_params.size(), 2);
   ASSERT_EQ(search_params.to_string(), "key1=value1&key2=value2");
   SUCCEED();
 }
+
+TEST(url_search_params, set) {
+  auto search_params = ada::url_search_params();
+  search_params.append("key1", "value1");
+  search_params.append("key1", "value2");
+  ASSERT_EQ(search_params.size(), 2);
+  search_params.set("key1", "hello");
+  ASSERT_EQ(search_params.size(), 1);
+  ASSERT_EQ(search_params.to_string(), "key1=hello");
+  SUCCEED();
+}