add an option to not include any urlpattern code (#904)

Author: anonrig

cmake/ada-flags.cmake

@@ -19,6 +19,7 @@ option(ADA_TOOLS "Build cli tools (adaparse)" OFF)
 option(ADA_BENCHMARKS "Build benchmarks" OFF)
 option(ADA_TESTING "Build tests" OFF)
 option(ADA_USE_UNSAFE_STD_REGEX_PROVIDER "Enable unsafe regex provider that uses std::regex" OFF)
+option(ADA_INCLUDE_URL_PATTERN "Include URL pattern implementation" ON)
 
 if (ADA_COVERAGE)
     message(STATUS "You want to compute coverage. We assume that you have installed gcovr.")

include/ada.h

@@ -29,11 +29,14 @@
 #include "ada/url_aggregator-inl.h"
 #include "ada/url_search_params.h"
 #include "ada/url_search_params-inl.h"
+
+#if ADA_INCLUDE_URL_PATTERN
 #include "ada/url_pattern.h"
 #include "ada/url_pattern-inl.h"
 #include "ada/url_pattern_helpers.h"
 #include "ada/url_pattern_helpers-inl.h"
 #include "ada/url_pattern_regex.h"
+#endif  // ADA_INCLUDE_URL_PATTERN
 
 // Public API
 #include "ada/ada_version.h"

include/ada/common_defs.h

@@ -262,4 +262,8 @@ namespace ada {
 #endif
 #endif
 
+#ifndef ADA_INCLUDE_URL_PATTERN
+#define ADA_INCLUDE_URL_PATTERN 1
+#endif  // ADA_INCLUDE_URL_PATTERN
+
 #endif  // ADA_COMMON_DEFS_H

include/ada/implementation-inl.h

@@ -4,7 +4,10 @@
 #ifndef ADA_IMPLEMENTATION_INL_H
 #define ADA_IMPLEMENTATION_INL_H
 
+#if ADA_INCLUDE_URL_PATTERN
 #include "ada/url_pattern_regex.h"
+#endif  // ADA_INCLUDE_URL_PATTERN
+
 #include "ada/expected.h"
 #include "ada/implementation.h"
 
@@ -13,6 +16,7 @@
 
 namespace ada {
 
+#if ADA_INCLUDE_URL_PATTERN
 template <url_pattern_regex::regex_concept regex_provider>
 ada_warn_unused tl::expected<url_pattern<regex_provider>, errors>
 parse_url_pattern(std::variant<std::string_view, url_pattern_init> input,
@@ -21,6 +25,7 @@ parse_url_pattern(std::variant<std::string_view, url_pattern_init> input,
   return parser::parse_url_pattern_impl<regex_provider>(std::move(input),
                                                         base_url, options);
 }
+#endif  // ADA_INCLUDE_URL_PATTERN
 
 }  // namespace ada
 

include/ada/implementation.h

@@ -13,7 +13,10 @@
 #include "ada/url.h"
 #include "ada/common_defs.h"
 #include "ada/errors.h"
+
+#if ADA_INCLUDE_URL_PATTERN
 #include "ada/url_pattern_init.h"
+#endif  // ADA_INCLUDE_URL_PATTERN
 
 namespace ada {
 
@@ -47,6 +50,7 @@ extern template ada::result<url_aggregator> parse<url_aggregator>(
 bool can_parse(std::string_view input,
                const std::string_view* base_input = nullptr);
 
+#if ADA_INCLUDE_URL_PATTERN
 /**
  * Implementation of the URL pattern parsing algorithm.
  * @see https://urlpattern.spec.whatwg.org
@@ -61,6 +65,7 @@ ada_warn_unused tl::expected<url_pattern<regex_provider>, errors>
 parse_url_pattern(std::variant<std::string_view, url_pattern_init> input,
                   const std::string_view* base_url = nullptr,
                   const url_pattern_options* options = nullptr);
+#endif  // ADA_INCLUDE_URL_PATTERN
 
 /**
  * Computes a href string from a file path. The function assumes

include/ada/parser-inl.h

@@ -5,15 +5,18 @@
 #define ADA_PARSER_INL_H
 
 #include "ada/expected.h"
+#if ADA_INCLUDE_URL_PATTERN
 #include "ada/url_pattern.h"
 #include "ada/url_pattern_helpers.h"
+#endif  // ADA_INCLUDE_URL_PATTERN
 #include "ada/parser.h"
 
 #include <string>
 #include <string_view>
 #include <variant>
 
 namespace ada::parser {
+#if ADA_INCLUDE_URL_PATTERN
 template <url_pattern_regex::regex_concept regex_provider>
 tl::expected<url_pattern<regex_provider>, errors> parse_url_pattern_impl(
     std::variant<std::string_view, url_pattern_init> input,
@@ -267,6 +270,7 @@ tl::expected<url_pattern<regex_provider>, errors> parse_url_pattern_impl(
   // Return urlPattern.
   return url_pattern_;
 }
+#endif  // ADA_INCLUDE_URL_PATTERN
 
 }  // namespace ada::parser
 

include/ada/parser.h

@@ -9,18 +9,23 @@
 #include <variant>
 
 #include "ada/expected.h"
+
+#if ADA_INCLUDE_URL_PATTERN
 #include "ada/url_pattern_regex.h"
 #include "ada/url_pattern_init.h"
+#endif  // ADA_INCLUDE_URL_PATTERN
 
 /**
  * @private
  */
 namespace ada {
 struct url_aggregator;
 struct url;
+#if ADA_INCLUDE_URL_PATTERN
 template <url_pattern_regex::regex_concept regex_provider>
 class url_pattern;
 struct url_pattern_options;
+#endif  // ADA_INCLUDE_URL_PATTERN
 enum class errors : uint8_t;
 }  // namespace ada
 
@@ -53,10 +58,12 @@ extern template url_aggregator parse_url_impl<url_aggregator>(
 extern template url parse_url_impl<url>(std::string_view user_input,
                                         const url* base_url);
 
+#if ADA_INCLUDE_URL_PATTERN
 template <url_pattern_regex::regex_concept regex_provider>
 tl::expected<url_pattern<regex_provider>, errors> parse_url_pattern_impl(
     std::variant<std::string_view, url_pattern_init> input,
     const std::string_view* base_url, const url_pattern_options* options);
+#endif  // ADA_INCLUDE_URL_PATTERN
 
 }  // namespace ada::parser
 

include/ada/url_aggregator.h

@@ -223,12 +223,15 @@ struct url_aggregator : url_base {
       std::string_view, const url_aggregator *);
   friend url_aggregator parser::parse_url_impl<url_aggregator, false>(
       std::string_view, const url_aggregator *);
+
+#if ADA_INCLUDE_URL_PATTERN
   // url_pattern methods
   template <url_pattern_regex::regex_concept regex_provider>
   friend tl::expected<url_pattern<regex_provider>, errors>
   parse_url_pattern_impl(std::variant<std::string_view, url_pattern_init> input,
                          const std::string_view *base_url,
                          const url_pattern_options *options);
+#endif  // ADA_INCLUDE_URL_PATTERN
 
   std::string buffer{};
   url_components components{};

src/CMakeLists.txt

@@ -59,3 +59,9 @@ endif()
 if(ADA_TESTING)
   target_compile_definitions(ada PRIVATE ADA_TESTING=1)
 endif()
+
+if(ADA_INCLUDE_URL_PATTERN)
+  target_compile_definitions(ada PRIVATE ADA_INCLUDE_URL_PATTERN=1)
+else()
+  target_compile_definitions(ada PRIVATE ADA_INCLUDE_URL_PATTERN=0)
+endif()

src/ada.cpp

@@ -8,7 +8,11 @@
 #include "parser.cpp"
 #include "url_components.cpp"
 #include "url_aggregator.cpp"
+
+#if ADA_INCLUDE_URL_PATTERN
 #include "url_pattern.cpp"
 #include "url_pattern_helpers.cpp"
 #include "url_pattern_regex.cpp"
+#endif  // ADA_INCLUDE_URL_PATTERN
+
 #include "ada_c.cpp"