Skip to content

Commit 63a407a

Browse files
committed
fix: use reference on several functions
1 parent 56c318f commit 63a407a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

include/ada/url_search_params-inl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ inline size_t url_search_params::size() const noexcept { return params.size(); }
2525

2626
inline std::optional<std::string_view> url_search_params::get(
2727
const std::string_view key) {
28-
auto entry = std::find_if(params.begin(), params.end(), [&key](auto param) {
28+
auto entry = std::find_if(params.begin(), params.end(), [&key](auto& param) {
2929
return std::get<0>(param) == key;
3030
});
3131

@@ -50,7 +50,7 @@ inline std::vector<std::string> url_search_params::get_all(
5050
}
5151

5252
inline bool url_search_params::has(const std::string_view key) noexcept {
53-
auto entry = std::find_if(params.begin(), params.end(), [&key](auto param) {
53+
auto entry = std::find_if(params.begin(), params.end(), [&key](auto& param) {
5454
return std::get<0>(param) == key;
5555
});
5656
return entry != params.end();

src/url_search_params.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ namespace ada {
1111
void url_search_params::remove(const std::string_view key) {
1212
params.erase(
1313
std::remove_if(params.begin(), params.end(),
14-
[&key](auto param) { return std::get<0>(param) == key; }),
14+
[&key](auto &param) { return std::get<0>(param) == key; }),
1515
params.end());
1616
}
1717

1818
void url_search_params::remove(const std::string_view key,
1919
std::string_view value) {
2020
params.erase(std::remove_if(params.begin(), params.end(),
21-
[&key, &value](auto param) {
21+
[&key, &value](auto &param) {
2222
return std::get<0>(param) == key &&
2323
std::get<1>(param) == value;
2424
}),
@@ -33,7 +33,7 @@ void url_search_params::set(const std::string_view key,
3333
const std::string_view value) {
3434
params.erase(
3535
std::remove_if(params.begin(), params.end(),
36-
[&key](auto param) { return std::get<0>(param) == key; }),
36+
[&key](auto &param) { return std::get<0>(param) == key; }),
3737
params.end());
3838

3939
params.emplace_back(std::string(key), std::string(value));

0 commit comments

Comments
 (0)