Skip to content

Commit 79ea5b2

Browse files
committed
fix: remove ada_clear_pathname
Implementors should prefer to call `ada_set_pathname('')` instead of `ada_clear_pathname`
1 parent 1d9c803 commit 79ea5b2

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

include/ada_c.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ void ada_set_hash(ada_url result, const char* input, size_t length);
8787
// url_aggregator clear methods
8888
void ada_clear_port(ada_url result);
8989
void ada_clear_hash(ada_url result);
90-
void ada_clear_pathname(ada_url result);
9190
void ada_clear_search(ada_url result);
9291

9392
// url_aggregator functions

src/ada_c.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -315,13 +315,6 @@ void ada_clear_hash(ada_url result) noexcept {
315315
}
316316
}
317317

318-
void ada_clear_pathname(ada_url result) noexcept {
319-
ada::result<ada::url_aggregator>& r = get_instance(result);
320-
if (r) {
321-
r->clear_pathname();
322-
}
323-
}
324-
325318
void ada_clear_search(ada_url result) noexcept {
326319
ada::result<ada::url_aggregator>& r = get_instance(result);
327320
if (r) {

tests/ada_c.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,6 @@ TEST(ada_c, setters) {
104104

105105
ada_set_pathname(url, "new-pathname", strlen("new-pathname"));
106106
ASSERT_EQ(convert_string(ada_get_pathname(url)), "/new-pathname");
107-
ada_clear_pathname(url);
108-
ASSERT_EQ(convert_string(ada_get_pathname(url)), "");
109107

110108
ada_set_search(url, "new-search", strlen("new-search"));
111109
ASSERT_EQ(convert_string(ada_get_search(url)), "?new-search");

0 commit comments

Comments
 (0)