feat: add url_search_params constructor

Author: anonrig

include/ada/url_search_params-inl.h

@@ -18,6 +18,47 @@
 
 namespace ada {
 
+inline void url_search_params::initialize(std::string_view input) {
+  if (input.front() == '?') {
+    input.remove_prefix(1);
+  }
+
+  auto process_key_value = [&](const std::string_view current) {
+    auto equal = current.find_first_of("=");
+
+    if (equal == std::string_view::npos) {
+      params.emplace_back(current, "");
+    } else {
+      auto plain_name = current.substr(0, equal);
+      auto plain_value = current.substr(equal + 1);
+      auto name =
+          unicode::percent_decode(plain_name, plain_name.find_first_of('%'));
+      auto value =
+          unicode::percent_decode(plain_value, plain_value.find_first_of('%'));
+
+      std::replace(name.begin(), name.end(), '+', ' ');
+      std::replace(value.begin(), value.end(), '+', ' ');
+
+      params.emplace_back(name, value);
+    }
+  };
+
+  while (!input.empty()) {
+    auto ampersand_index = input.find_first_of("&");
+
+    if (ampersand_index == std::string_view::npos) {
+      if (!input.empty()) {
+        process_key_value(input);
+      }
+      break;
+    } else if (ampersand_index != 0) {
+      process_key_value(input.substr(0, ampersand_index));
+    }
+
+    input.remove_prefix(ampersand_index + 1);
+  }
+}
+
 inline void url_search_params::append(const std::string_view key,
                                       const std::string_view value) {
   params.emplace_back(key, value);

include/ada/url_search_params.h

@@ -16,10 +16,14 @@ namespace ada {
  * @see https://url.spec.whatwg.org/#interface-urlsearchparams
  */
 struct url_search_params {
-  // TODO: Add missing constructors
-  // Add tests from
-  // https://github.com/web-platform-tests/wpt/blob/master/url/urlsearchparams-constructor.any.js
   url_search_params() = default;
+
+  /**
+   * @see
+   * https://github.com/web-platform-tests/wpt/blob/master/url/urlsearchparams-constructor.any.js
+   */
+  url_search_params(const std::string_view input) { initialize(input); }
+
   url_search_params(const url_search_params &u) = default;
   url_search_params(url_search_params &&u) noexcept = default;
   url_search_params &operator=(url_search_params &&u) noexcept = default;
@@ -72,6 +76,11 @@ struct url_search_params {
  private:
   typedef std::pair<std::string, std::string> key_value_pair;
   std::vector<key_value_pair> params{};
+
+  /**
+   * @see https://url.spec.whatwg.org/#concept-urlencoded-parser
+   */
+  void initialize(std::string_view init);
 };  // url_search_params
 
 }  // namespace ada

tests/url_search_params.cpp

@@ -109,3 +109,29 @@ TEST(url_search_params, sort) {
   ASSERT_EQ(search_params.to_string(), "aaa=first&bbb=second&ccc=third");
   SUCCEED();
 }
+
+TEST(url_search_params, string_constructor) {
+  auto p = ada::url_search_params("?a=b");
+  ASSERT_EQ(p.to_string(), "a=b");
+  SUCCEED();
+}
+
+TEST(url_search_params, string_constructor_without_value) {
+  auto p = ada::url_search_params("a=b&c");
+  ASSERT_EQ(p.to_string(), "a=b&c=");
+  SUCCEED();
+}
+
+// Taken from
+// https://github.com/web-platform-tests/wpt/blob/master/url/urlsearchparams-constructor.any.js
+TEST(url_search_params, string_constructor_with_edge_cases) {
+  auto p = ada::url_search_params("&a&&& &&&&&a+b=& c&m%c3%b8%c3%b8");
+  p.to_string();
+  ASSERT_TRUE(p.has("a"));
+  ASSERT_TRUE(p.has("a b"));
+  ASSERT_TRUE(p.has(" "));
+  ASSERT_TRUE(!p.has("c"));
+  ASSERT_TRUE(p.has(" c"));
+  ASSERT_TRUE(p.has("møø"));
+  SUCCEED();
+}