feat: add sort to url_search_params

Author: anonrig

include/ada/url_search_params.h

@@ -60,7 +60,7 @@ struct url_search_params {
   /**
    * @see https://url.spec.whatwg.org/#dom-urlsearchparams-sort
    */
-  void sort() const noexcept;
+  void sort();
 
   /**
    * @see https://url.spec.whatwg.org/#urlsearchparams-stringification-behavior

src/url_search_params.cpp

@@ -1,7 +1,7 @@
 #include "ada.h"
 #include "ada/url_search_params.h"
 
-#include <optional>
+#include <algorithm>
 #include <string>
 #include <string_view>
 #include <vector>
@@ -25,8 +25,12 @@ void url_search_params::remove(const std::string_view key,
                params.end());
 }
 
-void url_search_params::sort() const noexcept {
-  // TODO: Implement this
+void url_search_params::sort() {
+  typedef std::pair<std::string, std::string> key_value_pair;
+  std::stable_sort(params.begin(), params.end(),
+                   [](const key_value_pair &lhs, const key_value_pair &rhs) {
+                     return lhs.first < rhs.first;
+                   });
 }
 
 void url_search_params::set(const std::string_view key,

tests/url_search_params.cpp

@@ -45,3 +45,14 @@ TEST(url_search_params, remove) {
   ASSERT_EQ(search_params.to_string(), "key1=value1");
   SUCCEED();
 }
+
+TEST(url_search_params, sort) {
+  auto search_params = ada::url_search_params();
+  search_params.append("bbb", "second");
+  search_params.append("aaa", "first");
+  search_params.append("ccc", "third");
+  ASSERT_EQ(search_params.size(), 3);
+  search_params.sort();
+  ASSERT_EQ(search_params.to_string(), "aaa=first&bbb=second&ccc=third");
+  SUCCEED();
+}