Revert "Reapply "revert to solution with broken windows""

This reverts commit d206887.

Author: dario-piotrowicz

src/version_weaver.cpp

@@ -37,6 +37,7 @@ std::string minimum(std::string_view range) { return ""; }
 std::expected<std::string, parse_error> inc(version input,
                                             release_type release_type) {
   version_weaver::version result;
+  std::string incremented;
   switch (release_type) {
     case MAJOR:
     case PRE_MAJOR: {
@@ -48,8 +49,8 @@ std::expected<std::string, parse_error> inc(version input,
         return std::unexpected(parse_error::INVALID_MAJOR);
       }
       auto incremented_major_int = major_int + 1;
-      auto major = std::to_string(incremented_major_int);
-      result = version_weaver::version{major, "0", "0"};
+      incremented = std::to_string(incremented_major_int);
+      result = version_weaver::version{incremented, "0", "0"};
       break;
     }
     case MINOR:
@@ -62,8 +63,8 @@ std::expected<std::string, parse_error> inc(version input,
         return std::unexpected(parse_error::INVALID_MINOR);
       }
       auto incremented_minor_int = minor_int + 1;
-      result = version_weaver::version{
-          input.major, std::to_string(incremented_minor_int), "0"};
+      incremented = std::to_string(incremented_minor_int);
+      result = version_weaver::version{input.major, incremented, "0"};
       break;
     }
     case PATCH:
@@ -86,9 +87,9 @@ std::expected<std::string, parse_error> inc(version input,
           return std::unexpected(parse_error::INVALID_PRERELEASE);
         }
         auto incremented_prerelease_int = prerelease_int + 1;
-        return version_weaver::version{
-            input.major, input.minor, input.patch,
-            std::to_string(incremented_prerelease_int)};
+        incremented = std::to_string(incremented_prerelease_int);
+        return version_weaver::version{input.major, input.minor, input.patch,
+                                       incremented};
       }
       int patch_int;
       auto [ptr, ec] =
@@ -98,8 +99,8 @@ std::expected<std::string, parse_error> inc(version input,
         return std::unexpected(parse_error::INVALID_PATCH);
       }
       auto incremented_patch_int = patch_int + 1;
-      result = version_weaver::version{input.major, input.minor,
-                                       std::to_string(incremented_patch_int)};
+      incremented = std::to_string(incremented_patch_int);
+      result = version_weaver::version{input.major, input.minor, incremented};
       break;
     }
     case RELEASE: {