Defined magic numbers in header file.

MODE2 does not contain RESTART bit (removed &0x7F operation)

Author: Bolukan

Adafruit_PWMServoDriver.cpp

@@ -46,7 +46,6 @@ Adafruit_PWMServoDriver::Adafruit_PWMServoDriver(uint8_t addr, TwoWire *i2c) {
  *  @brief  Setups the I2C interface and hardware
  *  @param  prescale
  *          Sets External Clock (Optional)
- *
  */
 void Adafruit_PWMServoDriver::begin(uint8_t prescale) {
   _i2c->begin();
@@ -63,7 +62,7 @@ void Adafruit_PWMServoDriver::begin(uint8_t prescale) {
  *  @brief  Sends a reset command to the PCA9685 chip over I2C
  */
 void Adafruit_PWMServoDriver::reset() {
-  write8(PCA9685_MODE1, 0x80);
+  write8(PCA9685_MODE1, MODE1_RESTART);
   delay(10);
 }
 
@@ -72,7 +71,7 @@ void Adafruit_PWMServoDriver::reset() {
  */
 void Adafruit_PWMServoDriver::sleep() {
   uint8_t awake = read8(PCA9685_MODE1);
-  uint8_t sleep = awake | 0x10; // set sleep bit high
+  uint8_t sleep = awake | MODE1_SLEEP; // set sleep bit high
   write8(PCA9685_MODE1, sleep);
   delay(5); // wait until cycle ends for sleep to be active
 }
@@ -82,31 +81,29 @@ void Adafruit_PWMServoDriver::sleep() {
  */
 void Adafruit_PWMServoDriver::wakeup() {
   uint8_t sleep = read8(PCA9685_MODE1);
-  uint8_t wakeup = sleep & ~0x10; // set sleep bit low
+  uint8_t wakeup = sleep & ~MODE1_SLEEP; // set sleep bit low
   write8(PCA9685_MODE1, wakeup);
 }
 
-/**************************************************************************/
 /*!
-    @brief  Sets EXTCLK pin to use the external clock
-       @param  prescale Configures the prescale value to be used by the external
-   clock
-*/
-/**************************************************************************/
+ *  @brief  Sets EXTCLK pin to use the external clock
+ *  @param  prescale
+ *          Configures the prescale value to be used by the external clock
+ */
 void Adafruit_PWMServoDriver::setExtClk(uint8_t prescale) {
   uint8_t oldmode = read8(PCA9685_MODE1);
-  uint8_t newmode = (oldmode & 0x7F) | 0x10; // sleep
+  uint8_t newmode = (oldmode & ~MODE1_RESTART) | MODE1_SLEEP; // sleep
   write8(PCA9685_MODE1, newmode); // go to sleep, turn off internal oscillator
 
   // This sets both the SLEEP and EXTCLK bits of the MODE1 register to switch to
   // use the external clock.
-  write8(PCA9685_MODE1, (newmode |= 0x40));
+  write8(PCA9685_MODE1, (newmode |= MODE1_EXTCLK));
 
   write8(PCA9685_PRESCALE, prescale); // set the prescaler
 
   delay(5);
-  write8(PCA9685_MODE1,
-         (newmode & ~(0x10)) | 0xa0); // clear the SLEEP bit to start
+  // clear the SLEEP bit to start
+  write8(PCA9685_MODE1, (newmode & ~MODE1_SLEEP) | MODE1_RESTART | MODE1_AI);
 
 #ifdef ENABLE_DEBUG_OUTPUT
   Serial.print("Mode now 0x");
@@ -124,8 +121,7 @@ void Adafruit_PWMServoDriver::setPWMFreq(float freq) {
   Serial.println(freq);
 #endif
 
-  freq *=
-      0.9; // Correct for overshoot in the frequency setting (see issue #11).
+  freq *= 0.9; // Correct for overshoot in the frequency setting (see issue #11).
   float prescaleval = 25000000;
   prescaleval /= 4096;
   prescaleval /= freq;
@@ -143,14 +139,13 @@ void Adafruit_PWMServoDriver::setPWMFreq(float freq) {
 #endif
 
   uint8_t oldmode = read8(PCA9685_MODE1);
-  uint8_t newmode = (oldmode & 0x7F) | 0x10; // sleep
+  uint8_t newmode = (oldmode & ~MODE1_RESTART) | MODE1_SLEEP; // sleep
   write8(PCA9685_MODE1, newmode);            // go to sleep
   write8(PCA9685_PRESCALE, prescale);        // set the prescaler
   write8(PCA9685_MODE1, oldmode);
   delay(5);
-  write8(PCA9685_MODE1,
-         oldmode |
-             0xa0); //  This sets the MODE1 register to turn on auto increment.
+  // This sets the MODE1 register to turn on auto increment.
+  write8(PCA9685_MODE1, oldmode | MODE1_RESTART | MODE1_AI); 
 
 #ifdef ENABLE_DEBUG_OUTPUT
   Serial.print("Mode now 0x");
@@ -169,10 +164,10 @@ void Adafruit_PWMServoDriver::setOutputMode(bool totempole) {
   uint8_t oldmode = read8(PCA9685_MODE2); 
   uint8_t newmode;
   if (totempole) {
-    newmode = (oldmode&0x7F) | 0x04;
+    newmode = oldmode | MODE2_OUTDRV;
   }
   else {
-    newmode = (oldmode&0x7F) & ~0x04;
+    newmode = oldmode & ~MODE2_OUTDRV;
   }
   write8(PCA9685_MODE2, newmode); 
 #ifdef ENABLE_DEBUG_OUTPUT
@@ -189,7 +184,7 @@ void Adafruit_PWMServoDriver::setOutputMode(bool totempole) {
  *  @return requested PWM output value
  */
 uint8_t Adafruit_PWMServoDriver::getPWM(uint8_t num) {
-  _i2c->requestFrom((int)_i2caddr, LED0_ON_L + 4 * num, (int)4);
+  _i2c->requestFrom((int)_i2caddr, PCA9685_LED0_ON_L + 4 * num, (int)4);
   return _i2c->read();
 }
 
@@ -210,7 +205,7 @@ void Adafruit_PWMServoDriver::setPWM(uint8_t num, uint16_t on, uint16_t off) {
 #endif
 
   _i2c->beginTransmission(_i2caddr);
-  _i2c->write(LED0_ON_L + 4 * num);
+  _i2c->write(PCA9685_LED0_ON_L + 4 * num);
   _i2c->write(on);
   _i2c->write(on >> 8);
   _i2c->write(off);

Adafruit_PWMServoDriver.h

@@ -25,30 +25,57 @@
 #include <Arduino.h>
 #include <Wire.h>
 
-#define PCA9685_SUBADR1 0x2 /**< i2c bus address 1 */
-#define PCA9685_SUBADR2 0x3 /**< i2c bus address 2 */
-#define PCA9685_SUBADR3 0x4 /**< i2c bus address 3 */
+// REGISTER ADDRESSES
+#define PCA9685_MODE1        0x00 /**< Mode Register 1 */
+#define PCA9685_MODE2        0x01 /**< Mode Register 2 */
+#define PCA9685_SUBADR1      0x02 /**< i2c bus address 1 */
+#define PCA9685_SUBADR2      0x03 /**< i2c bus address 2 */
+#define PCA9685_SUBADR3      0x04 /**< i2c bus address 3 */
+#define PCA9685_ALLCALLADR   0x05
+#define PCA9685_LED0_ON_L    0x06 /**< LED0 output and brightness control byte 0 */
+#define PCA9685_LED0_ON_H    0x07 /**< LED0 output and brightness control byte 1 */
+#define PCA9685_LED0_OFF_L   0x08 /**< LED0 output and brightness control byte 2 */
+#define PCA9685_LED0_OFF_H   0x09 /**< LED0 output and brightness control byte 3 */
+// etc all 16:  LED15_OFF_H 0x45
+#define PCA9685_ALLLED_ON_L  0xFA /**< load all the LEDn_ON registers, byte 0 */
+#define PCA9685_ALLLED_ON_H  0xFB /**< load all the LEDn_ON registers, byte 1 */
+#define PCA9685_ALLLED_OFF_L 0xFC /**< load all the LEDn_OFF registers, byte 0 */
+#define PCA9685_ALLLED_OFF_H 0xFD /**< load all the LEDn_OFF registers, byte 1 */
+#define PCA9685_PRESCALE     0xFE /**< Prescaler for PWM output frequency */
+#define PCA9685_TESTMODE     0xFF
 
-#define PCA9685_MODE1 0x0 /**< Mode Register 1 */
-#define PCA9685_MODE2 0x1 /**< Mode Register 2 */
-#define PCA9685_PRESCALE 0xFE /**< Prescaler for PWM output frequency */
+// MODE1 bits
+#define MODE1_ALLCAL         0x01
+#define MODE1_SUB3           0x02
+#define MODE1_SUB2           0x04
+#define MODE1_SUB1           0x08
+#define MODE1_SLEEP          0x10
+#define MODE1_AI             0x20
+#define MODE1_EXTCLK         0x40
+#define MODE1_RESTART        0x80
+// MODE2 bits
+#define MODE2_OUTNE_0        0x01
+#define MODE2_OUTNE_1        0x02
+#define MODE2_OUTDRV         0x04
+#define MODE2_OCH            0x08
+#define MODE2_INVRT          0x10
 
-#define LED0_ON_L 0x6 /**< LED0 output and brightness control byte 0 */
-#define LED0_ON_H 0x7 /**< LED0 output and brightness control byte 1 */
-#define LED0_OFF_L 0x8 /**< LED0 output and brightness control byte 2 */
-#define LED0_OFF_H 0x9 /**< LED0 output and brightness control byte 3 */
+// Default PCA9685 I2C Slave Address if A0-A5 are not set
+#define PCA9685_I2C_ADDRESS  0x40
 
-#define ALLLED_ON_L 0xFA /**< load all the LEDn_ON registers, byte 0 */
-#define ALLLED_ON_H 0xFB /**< load all the LEDn_ON registers, byte 1 */
-#define ALLLED_OFF_L 0xFC /**< load all the LEDn_OFF registers, byte 0 */
-#define ALLLED_OFF_H 0xFD /**< load all the LEDn_OFF registers, byte 1 */
+#define FREQUENCY_OSCILLATOR 25000000
+#define FREQUENCY_CALIBRATED 26075000 // measured 104.3% compared to official 25 MHz
+#define FREQUENCY_LEGACY     27777778 // Effect of freq /= 0,9
+
+#define PCA9685_PRESCALE_MIN 3
+#define PCA9685_PRESCALE_MAX 255
 
 /*! 
  *  @brief  Class that stores state and functions for interacting with PCA9685 PWM chip
  */
 class Adafruit_PWMServoDriver {
  public:
-  Adafruit_PWMServoDriver(uint8_t addr = 0x40, TwoWire *I2C = &Wire);
+  Adafruit_PWMServoDriver(uint8_t addr = PCA9685_I2C_ADDRESS, TwoWire *I2C = &Wire);
   void begin(uint8_t prescale = 0);
   void reset();
   void sleep();