Remove return_toml param

Author: justmobilize

src/adafruit_blinka/__init__.py

@@ -81,7 +81,7 @@ def unlock(self):
             self._locked = False
 
 
-def load_settings_toml(*, return_toml=False):
+def load_settings_toml():
     """Load values from settings.toml into os.environ, so that os.getenv returns them."""
     if not os.path.isfile("settings.toml"):
         raise FileNotFoundError("settings.toml not cound in current directory.")
@@ -111,9 +111,7 @@ def load_settings_toml(*, return_toml=False):
         os.environ[key] = str(value)
         print(f" - {key} added")
 
-    if return_toml:
-        return settings
-    return None
+    return settings
 
 
 def patch_system():

tests/test_load_settings_toml.py

@@ -79,15 +79,15 @@ def test_raises_with_no_file(self):
         with pytest.raises(
             FileNotFoundError, match="settings.toml not cound in current directory."
         ):
-            load_settings_toml(return_toml=True)
+            load_settings_toml()
 
     @mock.patch("adafruit_blinka.os.path.isfile", mock.Mock(return_value=True))
     @mock.patch("builtins.open", mock.mock_open(read_data=INVALID_TOML))
     def test_raises_with_invalid_file(self):
         with pytest.raises(
             tomllib.TOMLDecodeError, match="Error with settings.toml file."
         ):
-            load_settings_toml(return_toml=True)
+            load_settings_toml()
 
     @mock.patch("adafruit_blinka.os.path.isfile", mock.Mock(return_value=True))
     @mock.patch(
@@ -97,7 +97,7 @@ def test_raises_with_invalid_file_dict(self):
         with pytest.raises(
             ValueError, match="The types: 'dict' are not supported in settings.toml."
         ):
-            load_settings_toml(return_toml=True)
+            load_settings_toml()
 
     @mock.patch("adafruit_blinka.os.path.isfile", mock.Mock(return_value=True))
     @mock.patch(
@@ -107,7 +107,7 @@ def test_raises_with_invalid_file_list(self):
         with pytest.raises(
             ValueError, match="The types: 'list' are not supported in settings.toml."
         ):
-            load_settings_toml(return_toml=True)
+            load_settings_toml()
 
     @mock.patch("adafruit_blinka.os.path.isfile", mock.Mock(return_value=True))
     @mock.patch(
@@ -118,7 +118,7 @@ def test_raises_with_invalid_file_many(self):
             ValueError,
             match="The types: 'dict, list' are not supported in settings.toml.",
         ):
-            load_settings_toml(return_toml=True)
+            load_settings_toml()
 
     @mock.patch("adafruit_blinka.os.path.isfile", mock.Mock(return_value=True))
     @mock.patch(
@@ -129,7 +129,7 @@ def test_raises_with_invalid_file_nested(self):
         with pytest.raises(
             ValueError, match="The types: 'dict' are not supported in settings.toml."
         ):
-            load_settings_toml(return_toml=True)
+            load_settings_toml()
 
     @mock.patch("adafruit_blinka.os.path.isfile", mock.Mock(return_value=True))
     @mock.patch("builtins.open", mock.mock_open(read_data=VALID_TOML))
@@ -138,19 +138,7 @@ def test_returns_data(self):
         for key in CONVERTED_TOML:
             assert os.getenv(key) is None
 
-        assert load_settings_toml() is None
-
-        for key, value in CONVERTED_TOML.items():
-            assert os.getenv(key) == str(value)
-
-    @mock.patch("adafruit_blinka.os.path.isfile", mock.Mock(return_value=True))
-    @mock.patch("builtins.open", mock.mock_open(read_data=VALID_TOML))
-    @mock.patch.dict(os.environ, {}, clear=True)
-    def test_returns_data_when_asked(self):
-        for key in CONVERTED_TOML:
-            assert os.getenv(key) is None
-
-        assert load_settings_toml(return_toml=True) == CONVERTED_TOML
+        assert load_settings_toml() == CONVERTED_TOML
 
         for key, value in CONVERTED_TOML.items():
             assert os.getenv(key) == str(value)