Skip to content

Commit c2b7cb0

Browse files
committed
Address PR comments for adafruit_esp32spi.py
1 parent 842ac46 commit c2b7cb0

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

adafruit_esp32spi/adafruit_esp32spi.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
# pylint: disable=bad-whitespace
5555
_SET_NET_CMD = const(0x10)
5656
_SET_PASSPHRASE_CMD = const(0x11)
57-
_SET_AP_PASSPHRASE_CMD = const(0x19)
5857
_SET_DEBUG_CMD = const(0x1A)
5958

6059
_GET_CONN_STATUS_CMD = const(0x20)
@@ -629,22 +628,15 @@ def start_server(self, port, socket_num, conn_mode=TCP_MODE, ip=None): # pylint:
629628
if self._debug:
630629
print("*** starting server")
631630
self._socknum_ll[0][0] = socket_num
632-
port_param = struct.pack('>H', port)
633-
if ip: # use the 4 arg version
634-
resp = self._send_command_get_response(_START_SERVER_TCP_CMD,
635-
(ip,
636-
port_param,
637-
self._socknum_ll[0],
638-
(conn_mode,)))
639-
else: # use the 3 arg version
640-
resp = self._send_command_get_response(_START_SERVER_TCP_CMD,
641-
(port_param,
642-
self._socknum_ll[0],
643-
(conn_mode,)))
631+
params = [struct.pack('>H', port), self._socknum_ll[0], (conn_mode,)]
632+
if ip:
633+
params.insert(0, ip)
634+
resp = self._send_command_get_response(_START_SERVER_TCP_CMD, params)
635+
644636
if resp[0][0] != 1:
645637
raise RuntimeError("Could not start server")
646638

647-
def get_server_state(self, socket_num):
639+
def server_state(self, socket_num):
648640
"""Get the state of the ESP32's internal reference server socket number"""
649641
self._socknum_ll[0][0] = socket_num
650642
resp = self._send_command_get_response(_GET_STATE_TCP_CMD, self._socknum_ll)

0 commit comments

Comments
 (0)