Skip to content

Update network.py for Issue #7 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025
Merged

Update network.py for Issue #7 #11

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
153b177
Update network.py for Issue #7
TheKitty Aug 14, 2025
f3e13ff
Update network.py per comment
TheKitty Aug 14, 2025
d883e68
Update network.py
TheKitty Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adafruit_fruitjam/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def __init__( # noqa: PLR0913 Too many arguments in function definition
image_position=None,
image_dim_json_path=None,
):
print(f"status_neopixel", status_neopixel)
# print(f"status_neopixel", status_neopixel)
Copy link
Member

@brentru brentru Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the PR mentions debug printing, however the actual PR change is a comment. Was the print line meant to be commented out?

If we want to print only in debug mode as your PR mentions, instead of commenting this line out, check for the network class' debug kwarg and print if its true

Copy link
Contributor Author

@TheKitty TheKitty Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the line was used by the author to print the status and left in when the final version should not be printing the value to the serial monitor (stdout). @FoamyGuy is this correct?

Copy link
Contributor

@FoamyGuy FoamyGuy Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The print was put in during development to check on the status_neopixel state. It was left in accidentally.

I think it can just be removed entirely, no need to leave the commented version. If we did want to keep it then it can have logic added to check for debug like:

if debug:
    print(f"status_neopixel", status_neopixel)

Copy link
Contributor Author

@TheKitty TheKitty Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version removes the line per @FoamyGuy

if isinstance(status_neopixel, microcontroller.Pin):
status_led = neopixel.NeoPixel(status_neopixel, 1, brightness=0.2)
elif isinstance(status_neopixel, neopixel.NeoPixel):
Expand Down