Skip to content

Commit d4a8a8d

Browse files
committed
Removed HTTP... prefix from class names
1 parent 75ac0f2 commit d4a8a8d

File tree

9 files changed

+106
-120
lines changed

9 files changed

+106
-120
lines changed

adafruit_httpserver/authentication.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from binascii import b2a_base64
1616

1717
from .exceptions import AuthenticationError
18-
from .request import HTTPRequest
18+
from .request import Request
1919

2020

2121
class Basic:
@@ -38,9 +38,7 @@ def __str__(self) -> str:
3838
return f"Bearer {self._value}"
3939

4040

41-
def check_authentication(
42-
request: HTTPRequest, auths: List[Union[Basic, Bearer]]
43-
) -> bool:
41+
def check_authentication(request: Request, auths: List[Union[Basic, Bearer]]) -> bool:
4442
"""
4543
Returns ``True`` if request is authorized by any of the authentications, ``False`` otherwise.
4644
"""
@@ -53,9 +51,7 @@ def check_authentication(
5351
return any(auth_header == str(auth) for auth in auths)
5452

5553

56-
def require_authentication(
57-
request: HTTPRequest, auths: List[Union[Basic, Bearer]]
58-
) -> None:
54+
def require_authentication(request: Request, auths: List[Union[Basic, Bearer]]) -> None:
5955
"""
6056
Checks if the request is authorized and raises ``AuthenticationError`` if not.
6157

adafruit_httpserver/exceptions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
class AuthenticationError(Exception):
1212
"""
13-
Raised by ``require_authentication`` when the ``HTTPRequest`` is not authorized.
13+
Raised by ``require_authentication`` when the ``Request`` is not authorized.
1414
"""
1515

1616

@@ -42,7 +42,7 @@ def __init__(self, path: str) -> None:
4242

4343
class ResponseAlreadySentError(Exception):
4444
"""
45-
Another ``HTTPResponse`` has already been sent. There can only be one per ``HTTPRequest``.
45+
Another ``Response`` has already been sent. There can only be one per ``Request``.
4646
"""
4747

4848

adafruit_httpserver/headers.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# SPDX-License-Identifier: MIT
44
"""
5-
`adafruit_httpserver.headers.HTTPHeaders`
5+
`adafruit_httpserver.headers`
66
====================================================
77
* Author(s): Michał Pokusa
88
"""
@@ -13,7 +13,7 @@
1313
pass
1414

1515

16-
class HTTPHeaders:
16+
class Headers:
1717
"""
1818
A dict-like class for storing HTTP headers.
1919
@@ -23,7 +23,7 @@ class HTTPHeaders:
2323
2424
Examples::
2525
26-
headers = HTTPHeaders({"Content-Type": "text/html", "Content-Length": "1024"})
26+
headers = Headers({"Content-Type": "text/html", "Content-Length": "1024"})
2727
2828
len(headers)
2929
# 2
@@ -48,7 +48,6 @@ class HTTPHeaders:
4848
_storage: Dict[str, Tuple[str, str]]
4949

5050
def __init__(self, headers: Dict[str, str] = None) -> None:
51-
5251
headers = headers or {}
5352

5453
self._storage = {key.lower(): [key, value] for key, value in headers.items()}
@@ -81,7 +80,7 @@ def update(self, headers: Dict[str, str]):
8180

8281
def copy(self):
8382
"""Returns a copy of the headers."""
84-
return HTTPHeaders(dict(self._storage.values()))
83+
return Headers(dict(self._storage.values()))
8584

8685
def __getitem__(self, name: str):
8786
return self._storage[name.lower()][1]

adafruit_httpserver/methods.py

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,38 +2,35 @@
22
#
33
# SPDX-License-Identifier: MIT
44
"""
5-
`adafruit_httpserver.methods.HTTPMethod`
5+
`adafruit_httpserver.methods`
66
====================================================
77
* Author(s): Michał Pokusa
88
"""
99

1010

11-
class HTTPMethod: # pylint: disable=too-few-public-methods
12-
"""Enum with HTTP methods."""
11+
GET = "GET"
12+
"""GET method."""
1313

14-
GET = "GET"
15-
"""GET method."""
14+
POST = "POST"
15+
"""POST method."""
1616

17-
POST = "POST"
18-
"""POST method."""
17+
PUT = "PUT"
18+
"""PUT method"""
1919

20-
PUT = "PUT"
21-
"""PUT method"""
20+
DELETE = "DELETE"
21+
"""DELETE method"""
2222

23-
DELETE = "DELETE"
24-
"""DELETE method"""
23+
PATCH = "PATCH"
24+
"""PATCH method"""
2525

26-
PATCH = "PATCH"
27-
"""PATCH method"""
26+
HEAD = "HEAD"
27+
"""HEAD method"""
2828

29-
HEAD = "HEAD"
30-
"""HEAD method"""
29+
OPTIONS = "OPTIONS"
30+
"""OPTIONS method"""
3131

32-
OPTIONS = "OPTIONS"
33-
"""OPTIONS method"""
32+
TRACE = "TRACE"
33+
"""TRACE method"""
3434

35-
TRACE = "TRACE"
36-
"""TRACE method"""
37-
38-
CONNECT = "CONNECT"
39-
"""CONNECT method"""
35+
CONNECT = "CONNECT"
36+
"""CONNECT method"""

adafruit_httpserver/request.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# SPDX-License-Identifier: MIT
44
"""
5-
`adafruit_httpserver.request.HTTPRequest`
5+
`adafruit_httpserver.request`
66
====================================================
77
* Author(s): Dan Halbert, Michał Pokusa
88
"""
@@ -14,10 +14,10 @@
1414
except ImportError:
1515
pass
1616

17-
from .headers import HTTPHeaders
17+
from .headers import Headers
1818

1919

20-
class HTTPRequest:
20+
class Request:
2121
"""
2222
Incoming request, constructed from raw incoming bytes.
2323
It is passed as first argument to route handlers.
@@ -50,15 +50,15 @@ class HTTPRequest:
5050
5151
Example::
5252
53-
request = HTTPRequest(raw_request=b"GET /?foo=bar HTTP/1.1...")
53+
request = Request(raw_request=b"GET /?foo=bar HTTP/1.1...")
5454
request.query_params
5555
# {"foo": "bar"}
5656
"""
5757

5858
http_version: str
5959
"""HTTP version, e.g. "HTTP/1.1"."""
6060

61-
headers: HTTPHeaders
61+
headers: Headers
6262
"""
6363
Headers from the request.
6464
"""
@@ -143,11 +143,11 @@ def _parse_start_line(header_bytes: bytes) -> Tuple[str, str, Dict[str, str], st
143143
return method, path, query_params, http_version
144144

145145
@staticmethod
146-
def _parse_headers(header_bytes: bytes) -> HTTPHeaders:
146+
def _parse_headers(header_bytes: bytes) -> Headers:
147147
"""Parse HTTP headers from raw request."""
148148
header_lines = header_bytes.decode("utf8").splitlines()[1:]
149149

150-
return HTTPHeaders(
150+
return Headers(
151151
{
152152
name: value
153153
for header_line in header_lines

adafruit_httpserver/response.py

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# SPDX-License-Identifier: MIT
44
"""
5-
`adafruit_httpserver.response.HTTPResponse`
5+
`adafruit_httpserver.response`
66
====================================================
77
* Author(s): Dan Halbert, Michał Pokusa
88
"""
@@ -24,17 +24,17 @@
2424
ResponseAlreadySentError,
2525
)
2626
from .mime_type import MIMEType
27-
from .request import HTTPRequest
28-
from .status import HTTPStatus, CommonHTTPStatus
29-
from .headers import HTTPHeaders
27+
from .request import Request
28+
from .status import Status, CommonHTTPStatus
29+
from .headers import Headers
3030

3131

3232
def _prevent_multiple_send_calls(function: Callable):
3333
"""
3434
Decorator that prevents calling ``send`` or ``send_file`` more than once.
3535
"""
3636

37-
def wrapper(self: "HTTPResponse", *args, **kwargs):
37+
def wrapper(self: "Response", *args, **kwargs):
3838
if self._response_already_sent: # pylint: disable=protected-access
3939
raise ResponseAlreadySentError
4040

@@ -44,52 +44,52 @@ def wrapper(self: "HTTPResponse", *args, **kwargs):
4444
return wrapper
4545

4646

47-
class HTTPResponse:
47+
class Response:
4848
"""
49-
Response to a given `HTTPRequest`. Use in `HTTPServer.route` decorator functions.
49+
Response to a given `Request`. Use in `Server.route` handler functions.
5050
5151
Example::
5252
5353
# Response with 'Content-Length' header
5454
@server.route(path, method)
5555
def route_func(request):
5656
57-
response = HTTPResponse(request)
57+
response = Response(request)
5858
response.send("Some content", content_type="text/plain")
5959
6060
# or
6161
62-
response = HTTPResponse(request)
62+
response = Response(request)
6363
with response:
6464
response.send(body='Some content', content_type="text/plain")
6565
6666
# or
6767
68-
with HTTPResponse(request) as response:
68+
with Response(request) as response:
6969
response.send("Some content", content_type="text/plain")
7070
7171
# Response with 'Transfer-Encoding: chunked' header
7272
@server.route(path, method)
7373
def route_func(request):
7474
75-
response = HTTPResponse(request, content_type="text/plain", chunked=True)
75+
response = Response(request, content_type="text/plain", chunked=True)
7676
with response:
7777
response.send_chunk("Some content")
7878
response.send_chunk("Some more content")
7979
8080
# or
8181
82-
with HTTPResponse(request, content_type="text/plain", chunked=True) as response:
82+
with Response(request, content_type="text/plain", chunked=True) as response:
8383
response.send_chunk("Some content")
8484
response.send_chunk("Some more content")
8585
"""
8686

87-
request: HTTPRequest
87+
request: Request
8888
"""The request that this is a response to."""
8989

9090
http_version: str
91-
status: HTTPStatus
92-
headers: HTTPHeaders
91+
status: Status
92+
headers: Headers
9393
content_type: str
9494
"""
9595
Defaults to ``text/plain`` if not set.
@@ -102,9 +102,9 @@ def route_func(request):
102102

103103
def __init__( # pylint: disable=too-many-arguments
104104
self,
105-
request: HTTPRequest,
106-
status: Union[HTTPStatus, Tuple[int, str]] = CommonHTTPStatus.OK_200,
107-
headers: Union[HTTPHeaders, Dict[str, str]] = None,
105+
request: Request,
106+
status: Union[Status, Tuple[int, str]] = CommonHTTPStatus.OK_200,
107+
headers: Union[Headers, Dict[str, str]] = None,
108108
content_type: str = None,
109109
http_version: str = "HTTP/1.1",
110110
chunked: bool = False,
@@ -117,12 +117,12 @@ def __init__( # pylint: disable=too-many-arguments
117117
118118
To send the response, call ``send`` or ``send_file``.
119119
For chunked response use
120-
``with HTTPRequest(request, content_type=..., chunked=True) as r:`` and `send_chunk`.
120+
``with Response(request, content_type=..., chunked=True) as r:`` and `send_chunk`.
121121
"""
122122
self.request = request
123-
self.status = status if isinstance(status, HTTPStatus) else HTTPStatus(*status)
123+
self.status = status if isinstance(status, Status) else Status(*status)
124124
self.headers = (
125-
headers.copy() if isinstance(headers, HTTPHeaders) else HTTPHeaders(headers)
125+
headers.copy() if isinstance(headers, Headers) else Headers(headers)
126126
)
127127
self.content_type = content_type
128128
self.http_version = http_version
@@ -137,7 +137,7 @@ def _send_headers(
137137
"""
138138
Sends headers.
139139
Implicitly called by ``send`` and ``send_file`` and in
140-
``with HTTPResponse(request, chunked=True) as response:`` context manager.
140+
``with Response(request, chunked=True) as response:`` context manager.
141141
"""
142142
headers = self.headers.copy()
143143

@@ -259,7 +259,7 @@ def send_chunk(self, chunk: str = "") -> None:
259259
Sends chunk of response.
260260
261261
Should be used **only** inside
262-
``with HTTPResponse(request, chunked=True) as response:`` context manager.
262+
``with Response(request, chunked=True) as response:`` context manager.
263263
264264
:param str chunk: String data to be sent.
265265
"""

0 commit comments

Comments
 (0)