Skip to content

Commit 9721420

Browse files
author
BiffoBear
committed
Refactored old is_connected to _connected to maintain error checking purpose. Created new is_connected that returns a bool.
1 parent aec7777 commit 9721420

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

adafruit_minimqtt/adafruit_minimqtt.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ def connect(self, clean_session=True, host=None, port=None, keep_alive=None):
561561

562562
def disconnect(self):
563563
"""Disconnects the MiniMQTT client from the MQTT broker."""
564-
self.is_connected()
564+
self._connected()
565565
if self.logger is not None:
566566
self.logger.debug("Sending DISCONNECT packet to broker")
567567
try:
@@ -582,7 +582,7 @@ def ping(self):
582582
there is an active network connection.
583583
Returns response codes of any messages received while waiting for PINGRESP.
584584
"""
585-
self.is_connected()
585+
self._connected()
586586
if self.logger is not None:
587587
self.logger.debug("Sending PINGREQ")
588588
self._sock.send(MQTT_PINGREQ)
@@ -607,7 +607,7 @@ def publish(self, topic, msg, retain=False, qos=0):
607607
:param int qos: Quality of Service level for the message, defaults to zero.
608608
609609
"""
610-
self.is_connected()
610+
self._connected()
611611
self._valid_topic(topic)
612612
if "+" in topic or "#" in topic:
613613
raise MMQTTException("Publish topic can not contain wildcards.")
@@ -703,7 +703,7 @@ def subscribe(self, topic, qos=0):
703703
(send at least once), or ``2`` (send exactly once).
704704
705705
"""
706-
self.is_connected()
706+
self._connected()
707707
topics = None
708708
if isinstance(topic, tuple):
709709
topic, qos = topic
@@ -1046,14 +1046,23 @@ def _valid_qos(qos_level):
10461046
else:
10471047
raise MMQTTException("QoS must be an integer.")
10481048

1049-
def is_connected(self):
1049+
def _connected(self):
10501050
"""Returns MQTT client session status as True if connected, raises
10511051
a `MMQTTException` if `False`.
10521052
"""
10531053
if self._sock is None or self._is_connected is False:
10541054
raise MMQTTException("MiniMQTT is not connected.")
10551055
return self._is_connected
10561056

1057+
def is_connected(self):
1058+
"""Returns MQTT client session status as True if connected, False
1059+
if not.
1060+
"""
1061+
try:
1062+
return self._connected()
1063+
except MMQTTException:
1064+
return False
1065+
10571066
# Logging
10581067
def enable_logger(self, logger, log_level=20):
10591068
"""Enables library logging provided a logger object.

0 commit comments

Comments
 (0)