The core doesn't like sideset_pin_count=0, so don't send it

Author: jepler

adafruit_pioasm.py

@@ -224,10 +224,12 @@ def __init__(self, text_program: str, *, build_debuginfo=False) -> None:
             # print(bin(assembled[-1]))
 
         self.pio_kwargs = {
-            "sideset_pin_count": sideset_count,
             "sideset_enable": sideset_enable,
         }
 
+        if sideset_count != 0:
+            self.pio_kwargs["sideset_pin_count"] = sideset_count
+
         if wrap is not None:
             self.pio_kwargs["wrap"] = wrap
         if wrap_target is not None:
@@ -255,9 +257,8 @@ def print_c_program(self, name, qualifier="const"):
         print(
             f"{qualifier} int {name}_wrap_target = {self.pio_kwargs.get('wrap_target', 0)};"
         )
-        print(
-            f"{qualifier} int {name}_sideset_pin_count = {self.pio_kwargs['sideset_pin_count']};"
-        )
+        sideset_pin_count = self.pio_kwargs.get("sideset_pin_count", 0)
+        print(f"{qualifier} int {name}_sideset_pin_count = {sideset_pin_count};")
         print(
             f"{qualifier} bool {name}_sideset_enable = {self.pio_kwargs['sideset_enable']};"
         )

tests/testpioasm.py

@@ -111,7 +111,7 @@ def testLimits(self):
         self.assertAssemblyFails(".side_set 1 opt\nnop side 0 [8]")
 
     def testCls(self):
-        self.assertPioKwargs("", sideset_pin_count=0, sideset_enable=False)
+        self.assertPioKwargs("", sideset_enable=False)
         self.assertPioKwargs(".side_set 1", sideset_pin_count=1, sideset_enable=False)
         self.assertPioKwargs(
             ".side_set 3 opt", sideset_pin_count=3, sideset_enable=True
@@ -143,7 +143,6 @@ def testWrap(self):
         self.assertAssemblyFails(".wrap")
         self.assertPioKwargs(
             "nop\n.wrap_target\nnop\nnop\n.wrap",
-            sideset_pin_count=0,
             sideset_enable=False,
             wrap=2,
             wrap_target=1,