Removed TODO notes

Author: BiffoBear

adafruit_wiznet5k/adafruit_wiznet5k_dhcp.py

@@ -254,7 +254,7 @@ def send_dhcp_message(
     # pylint: disable=too-many-branches, too-many-statements
     def parse_dhcp_response(
         self,
-    ) -> Union[Tuple[int, bytes], Tuple[int, int]]:  # TODO: ****
+    ) -> Union[Tuple[int, bytes], Tuple[int, int]]:
         """Parse DHCP response from DHCP server.
 
         :return Union[Tuple[int, bytes], Tuple[int, int]]: DHCP packet type.
@@ -272,13 +272,11 @@ def parse_dhcp_response(
             DHCP message OP is not expected BOOT Reply."
 
         xid = _BUFF[4:8]
-        # TODO: ValueError bytes & int
         if bytes(xid) < self._initial_xid:
             print("f")
             return 0, 0
 
         self.local_ip = tuple(_BUFF[16:20])
-        # TODO: Don't think this will ever be True
         if _BUFF[28:34] == 0:
             return 0, 0
 
@@ -424,7 +422,6 @@ def _dhcp_state_machine(self) -> None:
                 if msg_type == DHCP_OFFER:
                     # Check if transaction ID matches, otherwise it may be an offer
                     # for another device
-                    # TODO: xid is already an int
                     if htonl(self._transaction_id) == int.from_bytes(xid, "big"):
                         if self._debug:
                             print(
@@ -449,7 +446,6 @@ def _dhcp_state_machine(self) -> None:
                 msg_type, xid = self.parse_dhcp_response()
                 # Check if transaction ID matches, otherwise it may be
                 # for another device
-                # TODO: xid is already an int
                 if htonl(self._transaction_id) == int.from_bytes(xid, "big"):
                     if msg_type == DHCP_ACK:
                         if self._debug:

adafruit_wiznet5k/adafruit_wiznet5k_dns.py

@@ -66,7 +66,7 @@ def __init__(
         self._sock.settimeout(1)
 
         self._dns_server = dns_address
-        self._host = 0  # TODO: make b"" to resolve a type error with .decode in _build_dns_ques...
+        self._host = 0
         self._request_id = 0  # request identifier
         self._pkt_buf = bytearray()
 
@@ -78,7 +78,6 @@ def gethostbyname(self, hostname: bytes) -> Union[int, bytes]:
 
         :return Union[int, bytes] The IPv4 address if successful, -1 otherwise.
         """
-        # TODO: See if it will take a string.
         if self._dns_server is None:
             return INVALID_SERVER
         self._host = hostname
@@ -143,7 +142,7 @@ def _parse_dns_response(
             return -1
         # Validate flags
         flags = int.from_bytes(self._pkt_buf[2:4], "big")
-        if not flags in (0x8180, 0x8580):  # TODO: Should be `flags not in ...`
+        if not flags in (0x8180, 0x8580):
             if self._debug:
                 print("* DNS ERROR: Invalid flags, ", flags)
             return -1

adafruit_wiznet5k/adafruit_wiznet5k_ntp.py

@@ -37,7 +37,7 @@ def __init__(
         self,
         iface: adafruit_wiznet5k.WIZNET5K,
         ntp_address: str,
-        utc: int,  # TODO: Should be float. India is UTC + 7.5
+        utc: int,
         debug: bool = False,
     ) -> None:
         """

adafruit_wiznet5k/adafruit_wiznet5k_socket.py

@@ -93,8 +93,6 @@ def getaddrinfo(
     :param int proto: Unused in this implementation of socket.
     :param int flags: Unused in this implementation of socket.
     """
-    # TODO: Python socket accepts port as a string or int or None. How are str and None handled?
-    # TODO: Python socket has arg type in place of socktype.
     if not isinstance(port, int):
         raise RuntimeError("Port must be an integer")
     if is_ipv4(host):
@@ -322,7 +320,6 @@ def accept(
         self._socknum = new_listen_socknum  # pylint: disable=protected-access
         self.bind((None, self._listen_port))
         self.listen()
-        # TODO: Weird logic below. Should be an if, not a while
         while self.status != wiznet5k.adafruit_wiznet5k.SNSR_SOCK_LISTEN:
             raise RuntimeError("Failed to open new listening socket")
         return client_sock, addr
@@ -340,7 +337,6 @@ def connect(
         :param Optional[int] conntype: Raises an exception if set to 3, unused otherwise, defaults
             to None.
         """
-        # TODO: conntype unused beyond raising an exception.
         assert (
             conntype != 0x03
         ), "Error: SSL/TLS is not currently supported by CircuitPython."
@@ -380,7 +376,7 @@ def sendto(self, data: bytearray, address: [Tuple[str, int]]) -> None:
         :param tuple address: Remote socket as a (host, port) tuple.
         """
         self.connect(address)
-        return self.send(data)  # TODO: send only returns None, so can delete
+        return self.send(data)
 
     def recv(
         # pylint: disable=too-many-branches
@@ -431,17 +427,15 @@ def recv(
                 elif self._sock_type == SOCK_DGRAM:
                     recv = _the_interface.read_udp(self.socknum, min(to_read, avail))[1]
                     to_read = len(recv)  # only get this dgram
-                recv = bytes(
-                    recv
-                )  # TODO: Maybe raise a specific exception before this line
+                recv = bytes(recv)
                 received.append(recv)
                 to_read -= len(recv)
                 gc.collect()
             if self._timeout > 0 and time.monotonic() - stamp > self._timeout:
                 break
         self._buffer += b"".join(received)
 
-        ret = None  # TODO: Unused definition
+        ret = None
         if len(self._buffer) == bufsize:
             ret = self._buffer
             self._buffer = b""
@@ -463,9 +457,8 @@ def embed_recv(
 
         :return bytes: All data available from the connection.
         """
-        # TODO: bufsize unused
         # print("Socket read", bufsize)
-        ret = None  # TODO: Useless definition
+        ret = None
         avail = self.available()
         if avail:
             if self._sock_type == SOCK_STREAM: