Modify accept() behaviour to match core sockets

Author: fasteddy516

adafruit_wiznet5k/adafruit_wiznet5k_socketpool.py

@@ -408,33 +408,50 @@ def accept(
             end of the connection.
         """
         stamp = ticks_ms()
-        while self._status not in (
-            wiznet5k.adafruit_wiznet5k.SNSR_SOCK_SYNRECV,
-            wiznet5k.adafruit_wiznet5k.SNSR_SOCK_ESTABLISHED,
-            wiznet5k.adafruit_wiznet5k.SNSR_SOCK_LISTEN,
-        ):
+        while True:
+            while self._status not in (
+                wiznet5k.adafruit_wiznet5k.SNSR_SOCK_SYNRECV,
+                wiznet5k.adafruit_wiznet5k.SNSR_SOCK_ESTABLISHED,
+                wiznet5k.adafruit_wiznet5k.SNSR_SOCK_LISTEN,
+            ):
+                if (
+                    self._timeout
+                    and 0 < self._timeout < ticks_diff(ticks_ms(), stamp) / 1000
+                ):
+                    raise TimeoutError("Failed to accept connection.")
+                if self._status == wiznet5k.adafruit_wiznet5k.SNSR_SOCK_CLOSE_WAIT:
+                    self._disconnect()
+                    self.listen()
+                if self._status == wiznet5k.adafruit_wiznet5k.SNSR_SOCK_CLOSED:
+                    self.close()
+                    self.listen()
+    
+            _, addr = self._interface.socket_accept(self._socknum)
+            # if any of the following conditions are true, we haven't accepted a connection
             if (
-                self._timeout
-                and 0 < self._timeout < ticks_diff(ticks_ms(), stamp) / 1000
+                addr[0] == "0.0.0.0"
+                or addr[1] == 0
+                or self._interface.socket_status(self._socknum) != wiznet5k.adafruit_wiznet5k.SNSR_SOCK_ESTABLISHED
             ):
-                raise TimeoutError("Failed to accept connection.")
-            if self._status == wiznet5k.adafruit_wiznet5k.SNSR_SOCK_CLOSE_WAIT:
-                self._disconnect()
-                self.listen()
-            if self._status == wiznet5k.adafruit_wiznet5k.SNSR_SOCK_CLOSED:
-                self.close()
-                self.listen()
-
-        _, addr = self._interface.socket_accept(self._socknum)
-        current_socknum = self._socknum
-        # Create a new socket object and swap socket nums, so we can continue listening
-        client_sock = Socket(self._socket_pool)
-        self._socknum = client_sock._socknum  # pylint: disable=protected-access
-        client_sock._socknum = current_socknum  # pylint: disable=protected-access
-        self._bind((None, self._listen_port))
-        self.listen()
-        if self._status != wiznet5k.adafruit_wiznet5k.SNSR_SOCK_LISTEN:
-            raise RuntimeError("Failed to open new listening socket")
+                if self._timeout == 0:
+                    # non-blocking mode
+                    raise OSError(errno.EAGAIN)
+                elif self._timeout and 0 < self._timeout < ticks_diff(ticks_ms(), stamp) / 1000:
+                    # blocking mode with timeout
+                    raise OSError(errno.ETIMEDOUT)
+                else:
+                    # blocking mode / timeout not expired
+                    continue
+            current_socknum = self._socknum
+            # Create a new socket object and swap socket nums, so we can continue listening
+            client_sock = Socket(self._socket_pool)
+            self._socknum = client_sock._socknum  # pylint: disable=protected-access
+            client_sock._socknum = current_socknum  # pylint: disable=protected-access
+            self._bind((None, self._listen_port))
+            self.listen()
+            if self._status != wiznet5k.adafruit_wiznet5k.SNSR_SOCK_LISTEN:
+                raise RuntimeError("Failed to open new listening socket")
+            break
         return client_sock, addr
 
     @_check_socket_closed