Merge pull request #51 from adafruit/fix-warnings

Fix warnings

Author: ladyada

.github/workflows/githubci.yml

@@ -5,7 +5,21 @@ on: [pull_request, push, repository_dispatch]
 jobs:
   build:
     runs-on: ubuntu-latest
-    
+    strategy:
+      fail-fast: false
+      matrix:
+        arduino-platform:
+          - 'uno'
+          - 'leonardo'
+          - 'mega2560'
+          - 'esp8266'
+          - 'esp32'
+          - 'trinket_m0'
+          - 'cpb'
+          - 'cpx'
+          - 'metro_m0'
+          - 'metro_m4_tinyusb'
+
     steps:
     - uses: actions/setup-python@v1
       with:
@@ -26,10 +40,30 @@ jobs:
         git clone --quiet https://github.com/adafruit/Adafruit_SPIFlash.git /home/runner/Arduino/libraries/Adafruit_SPIFlash
 
     - name: test platforms
-      run: python3 ci/build_platform.py main_platforms metro_m4_tinyusb cpb cpx
+      run: python3 ci/build_platform.py ${{ matrix.arduino-platform }}
+
+  clang_and_doxy:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Setup Python
+      uses: actions/setup-python@v1
+      with:
+        python-version: '3.x'
+
+    - name: Checkout code
+      uses: actions/checkout@v2
+
+    - name: Checkout adafruit/ci-arduino
+      uses: actions/checkout@v2
+      with:
+         repository: adafruit/ci-arduino
+         path: ci
+
+    - name: pre-install
+      run: bash ci/actions_install.sh
 
     - name: clang
-      run: python3 ci/run-clang-format.py -e "ci/*" -e "bin/*" -r . 
+      run: python3 ci/run-clang-format.py -e "ci/*" -e "bin/*" -r .
 
     - name: doxygen
       env:

examples/EPDTest/EPDTest.ino

@@ -103,7 +103,7 @@ void loop() {
 }
 
 
-void testdrawtext(char *text, uint16_t color) {
+void testdrawtext(const char *text, uint16_t color) {
   display.setCursor(0, 0);
   display.setTextColor(color);
   display.setTextWrap(true);

examples/GizmoTest/GizmoTest.ino

@@ -84,7 +84,7 @@ void loop() {
 }
 
 
-void testdrawtext(char *text, uint16_t color) {
+void testdrawtext(const char *text, uint16_t color) {
   display.setCursor(0, 0);
   display.setTextColor(color);
   display.setTextWrap(true);

examples/ThinkInk_gray4/ThinkInk_gray4.ino

@@ -91,7 +91,7 @@ void loop() {
 }
 
 
-void testdrawtext(char *text, uint16_t color) {
+void testdrawtext(const char *text, uint16_t color) {
   display.setCursor(0, 0);
   display.setTextColor(color);
   display.setTextWrap(true);

examples/ThinkInk_mono/ThinkInk_mono.ino

@@ -101,7 +101,7 @@ void loop() {
 }
 
 
-void testdrawtext(char *text, uint16_t color) {
+void testdrawtext(const char *text, uint16_t color) {
   display.setCursor(0, 0);
   display.setTextColor(color);
   display.setTextWrap(true);

examples/ThinkInk_tricolor/ThinkInk_tricolor.ino

@@ -96,7 +96,7 @@ void loop() {
 }
 
 
-void testdrawtext(char *text, uint16_t color) {
+void testdrawtext(const char *text, uint16_t color) {
   display.setCursor(0, 0);
   display.setTextColor(color);
   display.setTextWrap(true);

examples/acep_7ColorTest/acep_7ColorTest.ino

@@ -81,7 +81,7 @@ void loop() {
 
 #define BUFFPIXEL 20
 
-bool bmpDraw(char *filename, int16_t x, int16_t y) {
+bool bmpDraw(const char *filename, int16_t x, int16_t y) {
   File     bmpFile;
   int      bmpWidth, bmpHeight;   // W+H in pixels
   uint8_t  bmpDepth;              // Bit depth (currently must be 24)
@@ -103,7 +103,7 @@ bool bmpDraw(char *filename, int16_t x, int16_t y) {
   Serial.println('\'');
 
   // Open requested file on SD card
-  if ((bmpFile = fatfs.open(filename, FILE_READ)) == NULL) {
+  if ((bmpFile = fatfs.open(filename, FILE_READ)) == false) {
     Serial.print(F("File not found"));
     return false;
   }

examples/graphicstest/graphicstest.ino

@@ -158,7 +158,7 @@ void testlines(uint16_t color) {
   display.display();
 }
 
-void testdrawtext(char *text, uint16_t color) {
+void testdrawtext(const char *text, uint16_t color) {
   display.clearBuffer();
   display.setCursor(5, 5);
   display.setTextColor(color);

src/Adafruit_EPD.cpp

@@ -312,6 +312,7 @@ void Adafruit_EPD::writeSRAMFramebufferToEPD(uint16_t SRAM_buffer_addr,
                                              uint32_t buffer_size,
                                              uint8_t EPDlocation,
                                              bool invertdata) {
+  (void)invertdata;
   uint8_t c;
   // use SRAM
   sram.csLow();
@@ -350,8 +351,6 @@ void Adafruit_EPD::writeSRAMFramebufferToEPD(uint16_t SRAM_buffer_addr,
 */
 /**************************************************************************/
 void Adafruit_EPD::display(bool sleep) {
-  uint8_t c;
-
 #ifdef EPD_DEBUG
   Serial.println("  Powering Up");
 #endif

src/Adafruit_MCPSRAM.cpp

@@ -146,7 +146,7 @@ void Adafruit_MCPSRAM::write(uint16_t addr, uint8_t *buf, uint16_t num,
   }
 
   // write buffer of data
-  for (int i = 0; i < num; i++) {
+  for (uint16_t i = 0; i < num; i++) {
 
     uint8_t d = buf[i];
 
@@ -224,7 +224,7 @@ void Adafruit_MCPSRAM::read(uint16_t addr, uint8_t *buf, uint16_t num,
   }
 
   // read data into buffer
-  for (int i = 0; i < num; i++) {
+  for (uint16_t i = 0; i < num; i++) {
 
     if (hwSPI) {
       buf[i] = _spi->transfer(0x00);