Skip to content

Commit a77b311

Browse files
author
brentru
committed
all tests without expectedFailure pass
1 parent 0495b89 commit a77b311

File tree

2 files changed

+30
-25
lines changed

2 files changed

+30
-25
lines changed

tests/test_client.py

Lines changed: 29 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def empty_feed(self, client, feed):
5050
data = client.data(feed)
5151
for d in data:
5252
client.delete(feed, d.id)
53-
53+
5454

5555
def test_set_key_and_username(self):
5656
username = "unique_username"
@@ -72,10 +72,10 @@ def test_send_batch_data(self):
7272
io = self.get_client()
7373
self.ensure_feed_deleted(io, 'testfeed')
7474
test_feed = io.create_feed(Feed(name="testfeed"))
75-
data_list = [Data(value='batch'), Data(value='batch')]
76-
io.send_batch_data(test_feed.key, 'foo')
77-
data = io.receive('testfeed')
78-
self.assertEqual(data.value, 'batch')
75+
data_list = [Data(value=42), Data(value=42)]
76+
io.send_batch_data(test_feed.key, data_list)
77+
data = io.receive(test_feed.key)
78+
self.assertEqual(int(data.value), 42)
7979

8080
def test_receive_next(self):
8181
io = self.get_client()
@@ -137,56 +137,60 @@ def test_append_by_feed_name(self):
137137

138138
def test_append_by_feed_key(self):
139139
io = self.get_client()
140-
self.ensure_feed_deleted(io, 'test feed fancy name')
141-
feed = io.create_feed(Feed(name='test feed fancy name'))
140+
self.ensure_feed_deleted(io, 'testfeed')
141+
feed = io.create_feed(Feed(name='testfeed'))
142142
result = io.append(feed.key, 42)
143143
self.assertEqual(int(result.value), 42)
144144

145145
def test_create_feed(self):
146146
io = self.get_client()
147-
self.ensure_feed_deleted(io, 'TestFeed')
148-
feed = Feed(name='TestFeed')
147+
self.ensure_feed_deleted(io, 'testfeed')
148+
feed = Feed(name='testfeed')
149149
result = io.create_feed(feed)
150-
self.assertEqual(result.name, 'TestFeed')
150+
self.assertEqual(result.name, 'testfeed')
151151

152152
def test_feeds_returns_all_feeds(self):
153153
io = self.get_client()
154-
io.send_data('TestFeed', 1) # Make sure TestFeed exists.
154+
self.ensure_feed_deleted(io, 'testfeed')
155+
feed = io.create_feed(Feed(name='testfeed'))
156+
io.send_data('testfeed', 1) # Make sure TestFeed exists.
155157
feeds = io.feeds()
156158
self.assertGreaterEqual(len(feeds), 1)
157159
names = set(map(lambda x: x.name, feeds))
158-
self.assertTrue('TestFeed' in names)
160+
self.assertTrue('testfeed' in names)
159161

160162
def test_feeds_returns_requested_feed(self):
161163
io = self.get_client()
162-
io.send_data('TestFeed', 1) # Make sure TestFeed exists.
163-
result = io.feeds('TestFeed')
164-
self.assertEqual(result.name, 'TestFeed')
165-
self.assertEqual(int(result.last_value), 1)
164+
self.ensure_feed_deleted(io, 'testfeed')
165+
feed = io.create_feed(Feed(name='testfeed'))
166+
io.send_data('testfeed', 1) # Make sure TestFeed exists.
167+
result = io.feeds('testfeed')
168+
self.assertEqual(result.name, 'testfeed')
166169

167170
def test_delete_feed(self):
168171
io = self.get_client()
169-
io.send_data('TestFeed', 'foo') # Make sure a feed called TestFeed exists.
170-
io.delete_feed('TestFeed')
171-
self.assertRaises(RequestError, io.receive, 'TestFeed')
172+
io.send_data('testfeed', 'foo') # Make sure a feed called TestFeed exists.
173+
io.delete_feed('testfeed')
174+
self.assertRaises(RequestError, io.receive, 'testfeed')
172175

173176
def test_delete_nonexistant_feed_fails(self):
174177
io = self.get_client()
175-
self.ensure_feed_deleted(io, 'TestFeed')
176-
self.assertRaises(RequestError, io.delete_feed, 'TestFeed')
178+
self.ensure_feed_deleted(io, 'testfeed')
179+
self.assertRaises(RequestError, io.delete_feed, 'testfeed')
177180

178181
def test_groups_returns_all_groups(self):
179182
io = self.get_client()
180183
groups = io.groups()
181184
self.assertGreaterEqual(len(groups), 1)
182185
names = set(map(lambda x: x.name, groups))
183-
self.assertTrue('GroupTest' in names)
186+
self.assertTrue('grouptest' in names)
184187

185188
def test_groups_retrieves_requested_group(self):
186189
io = self.get_client()
187-
response = io.groups('GroupTest')
188-
self.assertEqual(response.name, 'GroupTest')
189-
self.assertEqual(len(response.feeds), 2)
190+
self.ensure_group_deleted(io, 'grouptest')
191+
response = io.create_group(Group(name='grouptest'))
192+
self.assertEqual(response.name, 'grouptest')
193+
self.assertEqual(response.key, 'grouptest')
190194

191195
# BUG: Group create doesn't work: https://github.com/adafruit/io/issues/58
192196
@unittest.expectedFailure

tests/test_mqtt_client.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2020
# SOFTWARE.
2121
import time
22+
import unittest
2223

2324
from Adafruit_IO import MQTTClient
2425

0 commit comments

Comments
 (0)