Secrets Cleanup: C and E #2991
Secrets Cleanup: C and E #2991
Conversation
| except ImportError: | ||
| pass # File is optional, reaching here is not a program error | ||
|
|
||
| # Look for our name in settings.toml file if present |
There was a problem hiding this comment.
much simpler with using defaults
There was a problem hiding this comment.
removed and turned into settings.toml per discord convo
|
|
||
| """ | ||
| This demo is designed for the Kaluga development kit version 1.3 with the | ||
| ILI9341 display. Your secrets.py must be populated with your wifi credentials |
There was a problem hiding this comment.
this one doesn't use wifi or AIO
|
@FoamyGuy here's the next one! |
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
One minor thing noted below in a comment in the weather cloud code.
The rest of these code changes look good me.
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
I have updated the relevant guide pages that I can for these.
WeatherClould one needs changed after this is merged because it embedds the secrets.py file. I will do that after merging and post another comment confirming it's completed.
I had a look around for circuit stonks and the ESP32S2 wifi test one and came up empty.
For stonks I couldn't find anything that seemed to use this code. For ESP32S2 WIFI test this page seems like the closest fit: https://learn.adafruit.com/adafruit-esp32-s2-feather/circuitpython-internet-test but it's already updated for settings.toml, and it's pointing to a different code.py file that is inside one of the sub directories, not the one in the root of that folder that was edited in this PR.
|
The embed on WeatherCloud guide page has been updated. |
2 participants
Uh oh!
There was an error while loading. Please reload this page.