fix incompatibility with ov5640 and Pico #3017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to Adafruit_CircuitPython_OV5640 doubled the memory usage for a given quality setting. This makes the latest release of in CircuitPython incompatible with the previous quality setting=3 + colorspace=adafruit_ov5640.OV5640_COLOR_JPEG due to that working out an an allocation size of 204800. This is too much for the first Pico. Here is the breaking change: adafruit/Adafruit_CircuitPython_OV5640#35 Quality 4 is still too large at 153,600 bytes. Quality 5 using 122,880 works.
Contributor
|
@BlitzCityDIY This is in your guide. |
BlitzCityDIY
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Adafruit_CircuitPython_OV5640 doubled the memory usage for a given quality setting.
This makes the latest release of in CircuitPython incompatible with the previous settings of:
due to that working out an an allocation size of 204800. This is too much for the first Pico.
Here is the breaking change:
Quality 4 is still too large at 153,600 bytes.
Quality 5 using 122,880 works.
Successfully Tested on:
Note that Pico 2's could handle quality 3. May follow up with a subsequent PR that automatically picks the best quality for arbitrary platforms.