Skip to content

Commit 2696a45

Browse files
committed
update plan / todos
1 parent 87a3079 commit 2696a45

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

platformio.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ lib_deps =
9191
; Common build environment for ESP32 platform
9292
[common:esp32]
9393
platform = https://github.com/pioarduino/platform-espressif32/releases/download/51.03.07/platform-espressif32.zip
94-
; This is needed for occasional new features and bug fixes
94+
; develop branch is needed for occasional new features and bug fixes, main may be preferred
9595
; platform = https://github.com/pioarduino/platform-espressif32#develop
9696
lib_ignore = WiFiNINA, WiFi101, OneWire
9797
monitor_filters = esp32_exception_decoder, time

src/provisioning/tinyusb/Wippersnapper_FS.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,13 @@ bool Wippersnapper_FS::initFilesystem(bool force_format) {
159159
if (!wipperFatFs.begin(&flash))
160160
return false;
161161

162-
if (false) {
162+
if (false) { //TODO: reinstate after discussion over utility. Restest a full fs.
163163

164164
//TODO: Don't do this unless we need the space and createSecrets fails
165165
// If CircuitPython was previously installed - erase CPY FS
166166
eraseCPFS();
167167
// Also, should probably relabel drive to WIPPER if CIRCUITPY was there
168+
// using setVolumeLabel(), but note the FS must be unmounted first
168169
}
169170

170171

testplan.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
copy and analyse the hex difference for a corrupted file system versus freshly saved secrets + hunky dorey
2+
-- nulls for file entry - like we've erased the file and then rebooted (before writing the replacement)
3+
-- we do a lot of unnecessary file writing each boot, I'm optimising that to only if needed so normally there will be no file writes
24

35
retest first secrets.json acces on a new device on tinyUF2 0.18.2 and WS 88, versus tinyUF2 0.20.1 and WS88, then with no-ds-format-nor-file-recreation instead of WS88
6+
-- no-fs-format-nor-file-recreation branch has eliminated the issue
7+
8+
Cleanup eraseCPFS and retest with full file system and no secrets + different bootlog contents. also move write bootlog after secrets processing if not already
49

510
then add the metro-s3
611
Update step images in ws_boards for metro-s3

0 commit comments

Comments
 (0)