Skip to content

Commit 2cc6c07

Browse files
committed
🎨 Review dsx model
1 parent bbf4cad commit 2cc6c07

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/components/ds18x20/model.h

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,31 +26,29 @@ class DS18X20Model {
2626
public:
2727
DS18X20Model();
2828
~DS18X20Model();
29-
// Ds18x20Add Message
29+
// Ds18x20Add Message API
3030
bool DecodeDS18x20Add(pb_istream_t *stream);
3131
wippersnapper_ds18x20_Ds18x20Add *GetDS18x20AddMsg();
32-
// DS18x20Added Message
32+
// DS18x20Added Message API
3333
bool EncodeDS18x20Added(char *onewire_pin, bool is_init);
3434
wippersnapper_ds18x20_Ds18x20Added *GetDS18x20AddedMsg();
35-
// Ds18x20Remove Message
35+
// Ds18x20Remove Message API
3636
bool DecodeDS18x20Remove(pb_istream_t *stream);
3737
wippersnapper_ds18x20_Ds18x20Remove *GetDS18x20RemoveMsg();
38-
// Ds18x20Event Message
38+
// Ds18x20Event Message API
3939
bool EncodeDs18x20Event();
4040
wippersnapper_ds18x20_Ds18x20Event *GetDS18x20EventMsg();
41-
// TODO: move the below to private if we arent using it in controller?
42-
wippersnapper_ds18x20_Ds18x20Event
43-
_msg_DS18x20Event; ///< wippersnapper_ds18x20_Ds18x20Event message
4441
void InitDS18x20EventMsg(const char *ow_pin_name);
4542
void addSensorEvent(wippersnapper_sensor_SensorType sensor_type,
4643
float sensor_value);
47-
4844
private:
4945
wippersnapper_ds18x20_Ds18x20Add
5046
_msg_DS18x20Add; ///< wippersnapper_ds18x20_Ds18x20Add message
5147
wippersnapper_ds18x20_Ds18x20Added
5248
_msg_DS18x20Added; ///< wippersnapper_ds18x20_Ds18x20Added message
5349
wippersnapper_ds18x20_Ds18x20Remove
5450
_msg_DS18x20Remove; ///< wippersnapper_ds18x20_Ds18x20Remove message
51+
wippersnapper_ds18x20_Ds18x20Event
52+
_msg_DS18x20Event; ///< wippersnapper_ds18x20_Ds18x20Event message
5553
};
5654
#endif // WS_DIGITALIO_MODEL_H

0 commit comments

Comments
 (0)