Skip to content

Commit 420d319

Browse files
committed
address @tyeth review
1 parent a4d9e9d commit 420d319

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

platformio.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ lib_deps =
8181
adafruit/Adafruit TouchScreen
8282
adafruit/Adafruit MQTT Library
8383
bblanchon/ArduinoJson
84+
adafruit/Adafruit LiquidCrystal
8485
https://github.com/pstolarz/OneWireNg.git
8586
https://github.com/milesburton/Arduino-Temperature-Control-Library.git
8687
https://github.com/Sensirion/arduino-sht.git
@@ -91,7 +92,6 @@ lib_deps =
9192
https://github.com/Starmbi/hp_BH1750.git
9293
https://github.com/adafruit/Adafruit_TinyUSB_Arduino.git
9394
https://github.com/adafruit/Adafruit_LED_Backpack.git
94-
https://github.com/adafruit/Adafruit_LiquidCrystal.git
9595
https://github.com/adafruit/Adafruit_PM25AQI.git
9696

9797

src/Wippersnapper.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,12 @@ bool cbDecodeSignalRequestI2C(pb_istream_t *stream, const pb_field_t *field,
884884
"[app] ERROR: Failed decoding I2CDeviceOutputWrite message.");
885885
return false;
886886
}
887-
WS._i2cPort0->Handle_I2cDeviceOutputWrite(&msgDeviceWrite);
887+
888+
if (!WS._i2cPort0->Handle_I2cDeviceOutputWrite(&msgDeviceWrite)) {
889+
WS_DEBUG_PRINTLN("[app] ERROR: Failed to write to I2C output device.");
890+
return false; // fail out if we can't decode, we don't have a response to
891+
// publish
892+
}
888893
WS_DEBUG_PRINTLN("[app] I2C Device Output Write Done");
889894
} else {
890895
WS_DEBUG_PRINTLN("ERROR: Undefined I2C message tag");

0 commit comments

Comments
 (0)