Testing - Update NoFs.ino to work with Wokwi, add plumbing in app for signal publish, fix pwmadd and pwmremove handler issues found during testing

Author: brentru

examples/Wippersnapper_NoFS/Wippersnapper_NoFS.ino

@@ -1,36 +1,31 @@
-// Adafruit IO WipperSnapper Beta
-//
-//
-// NOTE: This software is a BETA release and in active development.
-// Please report bugs or errors to
-// https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/issues
+// Adafruit IO WipperSnapper
 //
 // This sketch is for devices which lack USB-MSD or LittleFS support such
-// as the Arduino MKR WiFi 1010, Arduino Nano 33 IoT.
+// as the ESP32Dev for Wokwi Simulator
 //
 // Adafruit invests time and resources providing this open source code.
 // Please support Adafruit and open source hardware by purchasing
 // products from Adafruit!
 //
-// Brent Rubell for Adafruit Industries, 2021
+// Brent Rubell for Adafruit Industries, 2025
 //
 // All text above must be included in any redistribution.
 
-#include "Wippersnapper_Networking.h"
-
+#include "ws_adapters.h"
+#define WS_DEBUG // Enable debug output
 /************************ Adafruit IO Config *******************************/
 
 // Visit io.adafruit.com if you need to create an account,
 // or if you need your Adafruit IO key.
 #define IO_USERNAME "YOUR_AIO_USERNAME"
 #define IO_KEY "YOUR_AIO_KEY"
-
+#define IO_URL "io.adafruit.com"
+#define IO_PORT 8883
 /**************************** WiFi Config ***********************************/
 #define WIFI_SSID "YOUR_WIFI_SSID"
 #define WIFI_PASS "YOUR_WIFI_PASSWORD"
 
-#include "Wippersnapper_Networking.h"
-ws_adapter_wifi wipper(IO_USERNAME, IO_KEY, WIFI_SSID, WIFI_PASS);
+ws_adapter_wifi wipper(IO_USERNAME, IO_KEY, WIFI_SSID, WIFI_PASS, IO_URL, IO_PORT);
 
 void setup() {
   // Provisioning must occur prior to serial init.

src/Wippersnapper_V2.cpp

@@ -1056,6 +1056,16 @@ bool Wippersnapper_V2::PublishSignal(pb_size_t which_payload, void *payload) {
     MsgSignal.payload.pixels_added =
         *(wippersnapper_pixels_PixelsAdded *)payload;
     break;
+  case wippersnapper_signal_DeviceToBroker_pwm_added_tag:
+    WS_DEBUG_PRINTLN("PWMAdded");
+    MsgSignal.which_payload = wippersnapper_signal_DeviceToBroker_pwm_added_tag;
+    MsgSignal.payload.pwm_added = *(wippersnapper_pwm_PWMAdded *)payload;
+    break;
+  case wippersnapper_signal_DeviceToBroker_servo_added_tag:
+    WS_DEBUG_PRINTLN("ServoAdded");
+    MsgSignal.which_payload = wippersnapper_signal_DeviceToBroker_servo_added_tag;
+    MsgSignal.payload.servo_added = *(wippersnapper_servo_ServoAdded *)payload;
+    break;
   default:
     WS_DEBUG_PRINTLN("ERROR: Invalid signal payload type, bailing out!");
     return false;

src/components/pwm/controller.cpp

@@ -95,15 +95,25 @@ bool PWMController::Handle_PWM_Remove(pb_istream_t *stream) {
   }
 
   // Detach and free the pin
-  _pwm_hardware[pin_idx]->DetachPin();
-  delete _pwm_hardware[pin_idx];
-  _pwm_hardware[pin_idx] = nullptr;
+  WS_DEBUG_PRINTLN("[pwm] Removing pin ");
+  WS_DEBUG_PRINTLN(pin);
+  if (_pwm_hardware[pin_idx] != nullptr) {
+    bool detach_result = _pwm_hardware[pin_idx]->DetachPin();
+    if (!detach_result) {
+      WS_DEBUG_PRINTLN("[pwm] Error: Failed to detach pin.");
+    }
+    delete _pwm_hardware[pin_idx];
+    _pwm_hardware[pin_idx] = nullptr;
+  } else {
+    WS_DEBUG_PRINTLN("[pwm] Error: Pin not attached!");
+  }
 
-  // Update _active_pwm_pins[]
+  // Reorganize _active_pwm_pins
   _active_pwm_pins--;
   for (int i = pin_idx; i < _active_pwm_pins; i++) {
     _pwm_hardware[i] = _pwm_hardware[i + 1];
   }
+  _pwm_hardware[_active_pwm_pins] = nullptr;
   return true;
 }
 

src/components/pwm/hardware.cpp

@@ -44,7 +44,7 @@ PWMHardware::~PWMHardware() {
 /**************************************************************************/
 bool PWMHardware::AttachPin(uint8_t pin, uint32_t frequency, uint32_t resolution) {
 #ifdef ARDUINO_ARCH_ESP32
-  _is_attached = ledcAttach(_pin, _frequency, _resolution);
+  _is_attached = ledcAttach(pin, frequency, resolution);
 #else
   _is_attached = true;
 #endif
@@ -73,12 +73,15 @@ bool PWMHardware::DetachPin() {
     bool did_detach = false;
     #ifdef ARDUINO_ARCH_ESP32
     did_detach = ledcDetach(_pin);
+    if (!did_detach) {
+        WS_DEBUG_PRINTLN("[pwm] Error: ledcDetach failed!");
+    }
     #else
+    digitalWrite(_pin, LOW); // "Disable" the pin's output
     did_detach = true;
     #endif
 
-    // "Disable" the pin's output
-    digitalWrite(_pin, LOW);
+    _is_attached = false; // always mark as false, for tracking
     return did_detach;
 }
 

src/components/pwm/hardware.h

@@ -46,4 +46,4 @@ class PWMHardware {
   uint32_t _resolution;
   uint32_t _duty_cycle;
 };
-#endif // WS_PWM_HARDWARE_H
+#endif // WS_PWM_HARDWARE_H

src/components/servo/controller.cpp

@@ -76,7 +76,7 @@ bool ServoController::Handle_Servo_Add(pb_istream_t *stream) {
   if (did_attach) {
     _servo_hardware[_active_servo_pins]->ServoWrite(MIN_SERVO_PULSE_WIDTH);
     WS_DEBUG_PRINT("[servo] Servo attached to pin: ");
-    WS_DEBUG_PRINT(msg_add->servo_pin);
+    WS_DEBUG_PRINTLN(msg_add->servo_pin);
     _active_servo_pins++;
   } else {
     WS_DEBUG_PRINTLN("[servo] Error: Failed to attach servo to pin!");