clang, fix offline test runner to install

Author: brentru

.github/workflows/release-caller-offline.yml

@@ -12,7 +12,7 @@ on:
 
 jobs:
   clang_and_doxy:
-    name: 🔎Clang & Doxygen
+    name: 🔎 Clang
     runs-on: ubuntu-latest
     steps:
       - uses: actions/setup-python@v5

.github/workflows/run-offline-tests.yml

@@ -2,45 +2,40 @@
 #
 # SPDX-License-Identifier: MIT
 name: WipperSnapper Tests for Offline Mode
-
 on:
-  pull_request:
-
+    release:
+      types: [published]
+      secrets:
+        GH_REPO_TOKEN:
+          required: true
 permissions:
   checks: write
   pull-requests: write
 
 jobs:
   build:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        test:
-          - test_offline
-      fail-fast: false
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v3
-
-      - name: Check out repository code
-        uses: actions/checkout@v3
-
+        uses: actions/checkout@v4
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
           python-version: '3.13'
-
       - name: Install Python dependencies
         run: |
           python -m pip install --upgrade pip
           pip install -r tests/requirements.txt
-
       - name: Install Wokwi CI server
         uses: wokwi/wokwi-ci-server-action@v1
-
       - name: Install Wokwi CLI
         run: curl -L https://wokwi.com/ci/install.sh | sh
-
+      - name: Install platformIO libraries
+        run: pio lib install
+      - name: Build PlatformIO examples
+        run: pio ci --board=esp32dev
+        env:
+          PLATFORMIO_CI_SRC: ${{ matrix.example }}
       - name: Test on Wokwi
         run: pytest tests/${{ matrix.test }}.py --junitxml=report.xml -v
         env:

platformio.ini

@@ -75,11 +75,11 @@ lib_deps =
     https://github.com/pstolarz/OneWireNg.git
     https://github.com/Sensirion/arduino-sht.git
     https://github.com/Sensirion/arduino-i2c-sen5x.git
-    https://github.com/Sensirion/arduino-i2c-scd4x.git#0.4.0
     https://github.com/adafruit/WiFiNINA.git
     https://github.com/Starmbi/hp_BH1750.git
     https://github.com/adafruit/RTClib.git
     https://github.com/bblanchon/ArduinoStreamUtils.git
+    https://github.com/Sensirion/arduino-i2c-scd4x.git
 
 ; Common build environment for ESP32 platform
 [common:esp32]

src/Wippersnapper_V2.h

@@ -213,8 +213,9 @@ class Wippersnapper_V2 {
   void BlinkKATStatus();
 
   // Error handling helpers
-  void
-  haltErrorV2(String error, ws_led_status_t ledStatusColor = WS_LED_STATUS_ERROR_RUNTIME, bool reboot = true);
+  void haltErrorV2(String error,
+                   ws_led_status_t ledStatusColor = WS_LED_STATUS_ERROR_RUNTIME,
+                   bool reboot = true);
   void errorWriteHangV2(String error);
 
   bool _is_offline_mode; ///< Global flag for if the device is in offline mode

src/Wippersnapper_demo.ino

@@ -9,8 +9,9 @@
 // All text above must be included in any redistribution.
 
 #include "ws_adapters.h"
-//ws_adapter_wifi wipper;
-ws_adapter_offline wipper;
+ws_adapter_wifi wipper;
+// Uncomment the following line to use the offline adapter for Pico
+// ws_adapter_offline wipper;
 
 #define WS_DEBUG // Enable debug output!
 

src/adapters/wifi/ws_wifi_esp8266.h

@@ -145,7 +145,8 @@ class ws_wifi_esp8266 : public Wippersnapper_V2 {
       if (WS._isWiFiMultiV2) {
         // multi network mode
         for (int j = 0; j < WS_MAX_ALT_WIFI_NETWORKS; j++) {
-          if (strcmp(WsV2._multiNetworksV2[j].ssid, WiFi.SSID(i).c_str()) == 0) {
+          if (strcmp(WsV2._multiNetworksV2[j].ssid, WiFi.SSID(i).c_str()) ==
+              0) {
             WS_DEBUG_PRINT("SSID (");
             WS_DEBUG_PRINT(WsV2._multiNetworksV2[j].ssid);
             WS_DEBUG_PRINT(") found! RSSI: ");

src/adapters/wifi/ws_wifi_ninafw.h

@@ -50,7 +50,7 @@ class ws_wifi_ninafw : public Wippersnapper {
   */
   /**************************************************************************/
   ws_wifi_ninafw(const char *aioUsername, const char *aioKey,
-                         const char *netSSID, const char *netPass)
+                 const char *netSSID, const char *netPass)
       : Wippersnapper() {
     _ssid = netSSID;
     _pass = netPass;

src/adapters/wifi/ws_wifi_pico.h

@@ -184,8 +184,8 @@ class ws_wifi_pico : public Wippersnapper_V2 {
               ? _aio_root_ca_prod
               : _aio_root_ca_staging);
       WsV2._mqttV2 = new Adafruit_MQTT_Client(
-          _mqtt_client_secure, WsV2._configV2.aio_url, WsV2._configV2.io_port, clientID,
-          WsV2._configV2.aio_user, WsV2._configV2.aio_key);
+          _mqtt_client_secure, WsV2._configV2.aio_url, WsV2._configV2.io_port,
+          clientID, WsV2._configV2.aio_user, WsV2._configV2.aio_key);
     } else {
       _mqtt_client_insecure = new WiFiClient();
       WsV2._mqttV2 = new Adafruit_MQTT_Client(
@@ -330,13 +330,13 @@ class ws_wifi_pico : public Wippersnapper_V2 {
 
         // Use the macro to retry the status check until connected / timed out
         int lastResult;
-/*         RETRY_FUNCTION_UNTIL_TIMEOUT(
-            []() -> int { return WiFi.status(); }, // Function call each cycle
-            int,                                   // return type
-            lastResult, // return variable (unused here)
-            [](int status) { return status == WL_CONNECTED; }, // check
-            PICO_CONNECT_TIMEOUT_MS,      // timeout interval (ms)
-            PICO_CONNECT_RETRY_DELAY_MS); // interval between retries */
+        /*         RETRY_FUNCTION_UNTIL_TIMEOUT(
+                    []() -> int { return WiFi.status(); }, // Function call each
+           cycle int,                                   // return type
+                    lastResult, // return variable (unused here)
+                    [](int status) { return status == WL_CONNECTED; }, // check
+                    PICO_CONNECT_TIMEOUT_MS,      // timeout interval (ms)
+                    PICO_CONNECT_RETRY_DELAY_MS); // interval between retries */
 
         if (lastResult == WL_CONNECTED) {
           _statusV2 = WS_NET_CONNECTED;

src/components/checkin/model.h

@@ -30,7 +30,7 @@ class CheckinModel {
   void CreateCheckinRequest(const char *hardware_uid,
                             const char *firmware_version);
   bool EncodeCheckinRequest();
-  wippersnapper_checkin_CheckinRequest* getCheckinRequest();
+  wippersnapper_checkin_CheckinRequest *getCheckinRequest();
   // Response Message
   bool DecodeCheckinResponse(pb_istream_t *stream);
   void ParseCheckinResponse();

src/components/digitalIO/hardware.h

@@ -31,6 +31,7 @@ class DigitalIOHardware {
   bool GetValue(uint8_t pin_name);
   void deinit(uint8_t pin_name);
   bool IsStatusLEDPin(uint8_t pin_name);
+
 private:
 };
 #endif // WS_DIGITALIO_HARDWARE_H