Skip to content

Commit fa3fe9f

Browse files
committed
chore(tidy): define magic numbers
1 parent 02dc790 commit fa3fe9f

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/components/i2c/drivers/WipperSnapper_I2C_Driver_SPA06_003.h

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@
1919
#include "WipperSnapper_I2C_Driver.h"
2020
#include <Adafruit_SPA06_003.h>
2121

22+
#define SPA06_003_TEMP_MIN -40.0 ///< Minimum valid temperature reading
23+
#define SPA06_003_TEMP_MAX 85.0 ///< Maximum valid temperature reading
24+
#define SPA06_003_PRESSURE_MIN \
25+
300.0 ///< Minimum valid pressure (9km above sea level)
26+
#define SPA06_003_PRESSURE_MAX \
27+
1100.0 ///< Maximum valid pressure (500m below sea level)
28+
2229
/**************************************************************************/
2330
/*!
2431
@brief Class that provides a sensor driver for the SPA06-003 PT sensor.
@@ -80,7 +87,8 @@ class WipperSnapper_I2C_Driver_SPA06_003 : public WipperSnapper_I2C_Driver {
8087
if (_spa06_003_temp == NULL)
8188
return false;
8289
success = _spa06_003_temp->getEvent(tempEvent);
83-
if (tempEvent->temperature > 85.0 || tempEvent->temperature < -40.0) {
90+
if (tempEvent->temperature > SPA06_003_TEMP_MAX ||
91+
tempEvent->temperature < SPA06_003_TEMP_MIN) {
8492
success = false;
8593
}
8694
return success;
@@ -102,7 +110,8 @@ class WipperSnapper_I2C_Driver_SPA06_003 : public WipperSnapper_I2C_Driver {
102110
return false;
103111
}
104112
success = _spa06_003_pressure->getEvent(pressureEvent);
105-
if (pressureEvent->pressure < 300.0 || pressureEvent->pressure > 1100.0) {
113+
if (pressureEvent->pressure < SPA06_003_PRESSURE_MIN ||
114+
pressureEvent->pressure > SPA06_003_PRESSURE_MAX) {
106115
success = false;
107116
}
108117
return success;

0 commit comments

Comments
 (0)