PR feedbacl

Author: tyeth

src/components/i2c/WipperSnapper_I2C.cpp

@@ -375,16 +375,16 @@ bool WipperSnapper_Component_I2C::initI2CDevice(
     WS_DEBUG_PRINTLN("LTR390 Initialized Successfully!");
   } else if ((strcmp("ltr329", msgDeviceInitReq->i2c_device_name) == 0) ||
              (strcmp("ltr303", msgDeviceInitReq->i2c_device_name) == 0)) {
-    _ltr329 = new WipperSnapper_I2C_Driver_LTR329(this->_i2c, i2cAddress);
+    _ltr329 = new WipperSnapper_I2C_Driver_LTR329_LTR303(this->_i2c, i2cAddress);
     if (!_ltr329->begin()) {
-      WS_DEBUG_PRINTLN("ERROR: Failed to initialize LTR329");
+      WS_DEBUG_PRINTLN("ERROR: Failed to initialize LTR329/303");
       _busStatusResponse =
           wippersnapper_i2c_v1_BusResponse_BUS_RESPONSE_DEVICE_INIT_FAIL;
       return false;
     }
     _ltr329->configureDriver(msgDeviceInitReq);
     drivers.push_back(_ltr329);
-    WS_DEBUG_PRINTLN("LTR329 Initialized Successfully!");
+    WS_DEBUG_PRINTLN("LTR329/303 Initialized Successfully!");
   } else if (strcmp("sgp30", msgDeviceInitReq->i2c_device_name) == 0) {
     _sgp30 = new WipperSnapper_I2C_Driver_SGP30(this->_i2c, i2cAddress);
     if (!_sgp30->begin()) {

src/components/i2c/WipperSnapper_I2C.h

@@ -37,7 +37,7 @@
 #include "drivers/WipperSnapper_I2C_Driver_LPS22HB.h"
 #include "drivers/WipperSnapper_I2C_Driver_LPS25HB.h"
 #include "drivers/WipperSnapper_I2C_Driver_LPS3XHW.h"
-#include "drivers/WipperSnapper_I2C_Driver_LTR329.h"
+#include "drivers/WipperSnapper_I2C_Driver_LTR329_LTR303.h"
 #include "drivers/WipperSnapper_I2C_Driver_LTR390.h"
 #include "drivers/WipperSnapper_I2C_Driver_MAX17048.h"
 #include "drivers/WipperSnapper_I2C_Driver_MCP9808.h"
@@ -121,7 +121,7 @@ class WipperSnapper_Component_I2C {
   WipperSnapper_I2C_Driver_HTU21D *_htu21d = nullptr;
   WipperSnapper_I2C_Driver_HTU31D *_htu31d = nullptr;
   WipperSnapper_I2C_Driver_INA219 *_ina219 = nullptr;
-  WipperSnapper_I2C_Driver_LTR329 *_ltr329 = nullptr;
+  WipperSnapper_I2C_Driver_LTR329_LTR303 *_ltr329 = nullptr;
   WipperSnapper_I2C_Driver_LTR390 *_ltr390 = nullptr;
   WipperSnapper_I2C_Driver_MCP9808 *_mcp9808 = nullptr;
   WipperSnapper_I2C_Driver_MPL115A2 *_mpl115a2 = nullptr;

src/components/i2c/drivers/WipperSnapper_I2C_Driver_LTR329.h renamed to src/components/i2c/drivers/WipperSnapper_I2C_Driver_LTR329_LTR303.h

@@ -1,7 +1,7 @@
 /*!
- * @file WipperSnapper_I2C_Driver_LTR329.h
+ * @file WipperSnapper_I2C_Driver_LTR329_LTR303.h
  *
- * Device driver for the LTR329 light sensor.
+ * Device driver for the LTR329 + LTR303 (329+interrupt) light sensors.
  *
  * Adafruit invests time and resources providing this open source code,
  * please support Adafruit and open-source hardware by purchasing
@@ -12,44 +12,44 @@
  * MIT license, all text here must be included in any redistribution.
  *
  */
-#ifndef WipperSnapper_I2C_Driver_LTR329_H
-#define WipperSnapper_I2C_Driver_LTR329_H
+#ifndef WipperSnapper_I2C_Driver_LTR329_LTR303_H
+#define WipperSnapper_I2C_Driver_LTR329_LTR303_H
 
 #include "WipperSnapper_I2C_Driver.h"
 #include <Adafruit_LTR329_LTR303.h>
 
 /**************************************************************************/
 /*!
-    @brief  Class that provides a driver interface for a LTR329 sensor.
+    @brief  Class that provides a driver interface for a LTR329/303 sensor.
 */
 /**************************************************************************/
-class WipperSnapper_I2C_Driver_LTR329 : public WipperSnapper_I2C_Driver {
+class WipperSnapper_I2C_Driver_LTR329_LTR303 : public WipperSnapper_I2C_Driver {
 public:
   /*******************************************************************************/
   /*!
-      @brief    Constructor for a LTR329 sensor.
+      @brief    Constructor for a LTR329/303 sensor.
       @param    i2c
                 The I2C interface.
       @param    sensorAddress
                 The 7-bit I2C address of the sensor.
   */
   /*******************************************************************************/
-  WipperSnapper_I2C_Driver_LTR329(TwoWire *i2c, uint16_t sensorAddress)
+  WipperSnapper_I2C_Driver_LTR329_LTR303(TwoWire *i2c, uint16_t sensorAddress)
       : WipperSnapper_I2C_Driver(i2c, sensorAddress) {
     _i2c = i2c;
     _sensorAddress = sensorAddress;
   }
 
   /*******************************************************************************/
   /*!
-      @brief    Destructor for an LTR329 sensor.
+      @brief    Destructor for an LTR329/303 sensor.
   */
   /*******************************************************************************/
-  ~WipperSnapper_I2C_Driver_LTR329() { delete _LTR329; }
+  ~WipperSnapper_I2C_Driver_LTR329_LTR303() { delete _LTR329; }
 
   /*******************************************************************************/
   /*!
-      @brief    Initializes the LTR329 sensor and begins I2C.
+      @brief    Initializes the LTR329/303 sensor and begins I2C.
       @returns  True if initialized successfully, False otherwise.
   */
   /*******************************************************************************/
@@ -72,7 +72,7 @@ class WipperSnapper_I2C_Driver_LTR329 : public WipperSnapper_I2C_Driver {
   /*!
       @brief    Reads the LTR329's ambient light level ([Visible+IR] - IR-only)
       @param    lightEvent
-                Light sensor reading, in lux.
+                Light sensor reading.
       @returns  True if the sensor event was obtained successfully, False
                 otherwise.
   */
@@ -120,4 +120,4 @@ class WipperSnapper_I2C_Driver_LTR329 : public WipperSnapper_I2C_Driver {
   uint16_t _delayBetweenReads;
 };
 
-#endif // WipperSnapper_I2C_Driver_LTR329
+#endif // WipperSnapper_I2C_Driver_LTR329_LTR303