Merge branch 'master' into develop

hathach · hathach · commit 5d2ea85b0711 · 2019-01-09T21:04:07.000+07:00
diff --git a/libraries/Bluefruit52Lib/src/BLECharacteristic.cpp b/libraries/Bluefruit52Lib/src/BLECharacteristic.cpp
@@ -539,7 +539,8 @@ bool BLECharacteristic::notify(const void* data, uint16_t len)
     while ( remaining )
     {
       // TODO multiple connection support
-      if ( !Bluefruit.Gap.getHvnPacket( Bluefruit.connHandle() ) )  return NRF_ERROR_RESOURCES; //BLE_ERROR_NO_TX_PACKETS;
+      // With no free buffers, give the app a channce to retry gracefully
+      if ( !Bluefruit.Gap.getHvnPacket( Bluefruit.connHandle() ) )  return false;
 
       uint16_t packet_len = min16(max_payload, remaining);
 

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,8 @@ bool BLECharacteristic::notify(const void* data, uint16_t len)`
`539`	`539`	`while ( remaining )`
`540`	`540`	`{`
`541`	`541`	`// TODO multiple connection support`
`542`		`- if ( !Bluefruit.Gap.getHvnPacket( Bluefruit.connHandle() ) ) return NRF_ERROR_RESOURCES; //BLE_ERROR_NO_TX_PACKETS;`
	`542`	`+ // With no free buffers, give the app a channce to retry gracefully`
	`543`	`+ if ( !Bluefruit.Gap.getHvnPacket( Bluefruit.connHandle() ) ) return false;`
`543`	`544`
`544`	`545`	`uint16_t packet_len = min16(max_payload, remaining);`
`545`	`546`