fix #108

hathach · hathach · commit 6478ca17bef9 · 2017-12-18T22:57:05.000+07:00
make sure all bits in OUTSET is set HIGH when reset
diff --git a/cores/nRF5/wiring.c b/cores/nRF5/wiring.c
@@ -56,6 +56,9 @@ void init( void )
   NRF_RTC1->INTENCLR    = RTC_INTENSET_COMPARE0_Msk;
   NRF_RTC1->TASKS_STOP  = 1;
   NRF_RTC1->TASKS_CLEAR = 1;
+
+  // Make sure all pin is set HIGH when pinmode() is called
+  NRF_GPIO->OUTSET = UINT32_MAX;
 }
 
 void enterSerialDfu(void)
diff --git a/libraries/SPI/SPI.cpp b/libraries/SPI/SPI.cpp
@@ -118,6 +118,7 @@ void SPIClass::beginTransaction(SPISettings settings)
 
 void SPIClass::endTransaction(void)
 {
+  _p_spi->ENABLE = (SPI_ENABLE_ENABLE_Disabled << SPI_ENABLE_ENABLE_Pos);
 }
 
 void SPIClass::setBitOrder(BitOrder order)

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,9 @@ void init( void )`
`56`	`56`	`NRF_RTC1->INTENCLR = RTC_INTENSET_COMPARE0_Msk;`
`57`	`57`	`NRF_RTC1->TASKS_STOP = 1;`
`58`	`58`	`NRF_RTC1->TASKS_CLEAR = 1;`
	`59`	`+`
	`60`	`+ // Make sure all pin is set HIGH when pinmode() is called`
	`61`	`+ NRF_GPIO->OUTSET = UINT32_MAX;`
`59`	`62`	`}`
`60`	`63`
`61`	`64`	`void enterSerialDfu(void)`
Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,7 @@ void SPIClass::beginTransaction(SPISettings settings)`
`118`	`118`
`119`	`119`	`void SPIClass::endTransaction(void)`
`120`	`120`	`{`
	`121`	`+ _p_spi->ENABLE = (SPI_ENABLE_ENABLE_Disabled << SPI_ENABLE_ENABLE_Pos);`
`121`	`122`	`}`
`122`	`123`
`123`	`124`	`void SPIClass::setBitOrder(BitOrder order)`