Skip to content

Commit b753287

Browse files
committed
Fix serial port names macro
1 parent 4533ddb commit b753287

File tree

3 files changed

+21
-16
lines changed

3 files changed

+21
-16
lines changed

cores/nRF5/Uart.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,8 @@ size_t Uart::write(const uint8_t *buffer, size_t size)
234234

235235
Uart SERIAL_PORT_HARDWARE( NRF_UARTE0, UARTE0_UART0_IRQn, PIN_SERIAL_RX, PIN_SERIAL_TX );
236236

237-
#ifdef HAVE_HWSERIAL2
238-
Uart Serial2( NRF_UARTE1, UARTE1_IRQn, PIN_SERIAL2_RX, PIN_SERIAL2_TX );
237+
#ifdef SERIAL_PORT_HARDWARE1
238+
Uart SERIAL_PORT_HARDWARE1( NRF_UARTE1, UARTE1_IRQn, PIN_SERIAL2_RX, PIN_SERIAL2_TX );
239239
#endif
240240

241241
extern "C"
@@ -245,10 +245,10 @@ extern "C"
245245
SERIAL_PORT_HARDWARE.IrqHandler();
246246
}
247247

248-
#ifdef HAVE_HWSERIAL2
248+
#ifdef SERIAL_PORT_HARDWARE1
249249
void UARTE1_IRQHandler()
250250
{
251-
Serial2.IrqHandler();
251+
SERIAL_PORT_HARDWARE1.IrqHandler();
252252
}
253253
#endif
254254
}

cores/nRF5/Uart.h

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#include "HardwareSerial.h"
2525
#include "RingBuffer.h"
2626
#include "rtos.h"
27+
#include "variant.h"
2728

2829
#include <cstddef>
2930

@@ -89,21 +90,23 @@ class Uart : public HardwareSerial
8990
// SERIAL_PORT_HARDWARE_OPEN Hardware serial ports which are open for use. Their RX & TX
9091
// pins are NOT connected to anything by default.
9192
#ifdef NRF52840_XXAA
93+
#define SERIAL_PORT_MONITOR Serial
94+
#define SERIAL_PORT_USBVIRTUAL Serial
9295

93-
#define SERIAL_PORT_MONITOR Serial
94-
#define SERIAL_PORT_USBVIRTUAL Serial
95-
96-
#define SERIAL_PORT_HARDWARE Serial1
97-
#define SERIAL_PORT_HARDWARE_OPEN Serial1
98-
99-
extern Uart Serial2;
100-
#define HAVE_HWSERIAL2
96+
#define SERIAL_PORT_HARDWARE Serial1
97+
#define SERIAL_PORT_HARDWARE_OPEN Serial1
10198

99+
#ifdef HAVE_HWSERIAL2
100+
#define SERIAL_PORT_HARDWARE1 Serial2
101+
#define SERIAL_PORT_HARDWARE_OPEN1 Serial2
102+
#endif
102103
#else
103-
104-
#define SERIAL_PORT_MONITOR Serial
105-
#define SERIAL_PORT_HARDWARE Serial
106-
104+
#define SERIAL_PORT_MONITOR Serial
105+
#define SERIAL_PORT_HARDWARE Serial
107106
#endif
108107

109108
extern Uart SERIAL_PORT_HARDWARE;
109+
110+
#ifdef SERIAL_PORT_HARDWARE1
111+
extern Uart SERIAL_PORT_HARDWARE1;
112+
#endif

variants/pca10056/variant.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ static const uint8_t AREF = PIN_AREF;
8686
/*
8787
* Serial interfaces
8888
*/
89+
#define HAVE_HWSERIAL2
90+
8991
#define PIN_SERIAL_RX (33)
9092
#define PIN_SERIAL_TX (34)
9193

0 commit comments

Comments
 (0)