clean up code

Author: hathach

changelog.md

@@ -27,12 +27,17 @@
   - Added Slow interval callback support via setSlowCallback()
 - Added setPresentationFormatDescriptor() support
 - Added addDescriptor() for BLECharacteritsic
-- Added set/get apperance
+- Added set/get appearance
 - Added experimental (work in progress) BLE Homekit
 - Enhanced bleuart to work with larger MTU
 - Partially support data length extension
 - Added BLECLientCharacteristic isValid() and read 8,16, 32 bit
 - Added cental_custom_hrm example for how to use client service and characteristic
+- BLECharacteristic
+  - Added read8(), read16(), read32(), write8(), write16(), write32(), notify8(), notify16(), notify32()
+  - Remove read(), write(), notify() with different uint8_t, uint16_t, uint32_t, int variant to prevent confusion
+- Added discover(), discovered() to BLEClientCharacteristic
+- Added getHandleRange() to BLEClientService
 
 ## Bug Fixs
 

libraries/Bluefruit52Lib/src/BLECharacteristic.cpp

@@ -421,28 +421,6 @@ uint16_t BLECharacteristic::write(const void* data, uint16_t len)
   return value.len;
 }
 
-uint16_t BLECharacteristic::write(int num)
-{
-  return write( (uint8_t*) &num, sizeof(num));
-}
-
-uint16_t BLECharacteristic::write(uint32_t num)
-{
-  return write( (uint8_t*) &num, sizeof(num));
-}
-
-uint16_t BLECharacteristic::write(uint16_t num)
-{
-  return write( (uint8_t*) &num, sizeof(num));
-}
-
-uint16_t BLECharacteristic::write(uint8_t  num)
-{
-  return write( (uint8_t*) &num, sizeof(num));
-}
-
-
-
 uint16_t BLECharacteristic::write8(uint8_t num)
 {
   return write( (uint8_t*) &num, sizeof(num));
@@ -488,21 +466,6 @@ uint16_t BLECharacteristic::read(void* buffer, uint16_t bufsize)
   return value.len;
 }
 
-uint16_t BLECharacteristic::read(uint32_t* num)
-{
-  return read(num, 4);
-}
-
-uint16_t BLECharacteristic::read(uint16_t* num)
-{
-  return read(num, 2);
-}
-
-uint16_t BLECharacteristic::read(uint8_t*  num)
-{
-  return read(num, 1);
-}
-
 uint8_t BLECharacteristic::read8(void)
 {
   uint8_t num;
@@ -618,24 +581,3 @@ bool BLECharacteristic::notify32(int num)
 {
   return notify32( (uint32_t) num);
 }
-
-
-bool BLECharacteristic::notify(int num)
-{
-  return notify( (uint8_t*) &num, sizeof(num));
-}
-
-bool BLECharacteristic::notify(uint32_t num)
-{
-  return notify( (uint8_t*) &num, sizeof(num));
-}
-
-bool BLECharacteristic::notify(uint16_t num)
-{
-  return notify( (uint8_t*) &num, sizeof(num));
-}
-
-bool BLECharacteristic::notify(uint8_t  num)
-{
-  return notify( (uint8_t*) &num, sizeof(num));
-}

libraries/Bluefruit52Lib/src/BLECharacteristic.h

@@ -121,11 +121,6 @@ class BLECharacteristic
     uint16_t write(const void* data, uint16_t len);
     uint16_t write(const char* str);
 
-    uint16_t write(int      num);
-    uint16_t write(uint32_t num);
-    uint16_t write(uint16_t num);
-    uint16_t write(uint8_t  num);
-
     uint16_t write8    (uint8_t  num);
     uint16_t write16   (uint16_t num);
     uint16_t write32   (uint32_t num);
@@ -134,9 +129,6 @@ class BLECharacteristic
 
     /*------------- Read -------------*/
     uint16_t read(void* buffer, uint16_t bufsize);
-    uint16_t read(uint32_t* num);
-    uint16_t read(uint16_t* num);
-    uint16_t read(uint8_t*  num);
 
     uint8_t  read8 (void);
     uint16_t read16(void);
@@ -153,11 +145,6 @@ class BLECharacteristic
     bool notify32   (uint32_t num);
     bool notify32   (int      num);
 
-    bool notify(int      num);
-    bool notify(uint32_t num);
-    bool notify(uint16_t num);
-    bool notify(uint8_t  num);
-
     /*------------- Internal Functions -------------*/
     virtual void _eventHandler(ble_evt_t* event);