Skip to content

Commit d89de25

Browse files
committed
clean up things
1 parent 8045b1e commit d89de25

File tree

6 files changed

+19
-10
lines changed

6 files changed

+19
-10
lines changed

boards.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ feather52840.menu.softdevice.s140v6.build.sd_name=s140
110110
feather52840.menu.softdevice.s140v6.build.sd_version=6.1.0
111111
feather52840.menu.softdevice.s140v6.build.sd_fwid=0x00AE
112112
feather52840.menu.softdevice.s140v6.build.ldscript=nrf52840_s140_v6.ld
113-
feather52840.menu.softdevice.s140v6.upload.maximum_size=303104
114-
feather52840.menu.softdevice.s140v6.upload.maximum_data_size=51072
113+
feather52840.menu.softdevice.s140v6.upload.maximum_size=552960
114+
feather52840.menu.softdevice.s140v6.upload.maximum_data_size=248832
115115

116116
# Debug Menu
117117
feather52840.menu.debug.l0=Level 0 (Release)
@@ -125,7 +125,7 @@ feather52840.menu.debug.l3.build.debug_flags=-DCFG_DEBUG=3 -Os
125125

126126

127127
#**********************************************
128-
# PCA10056 ( to be remove )
128+
# Nordic PCA10056
129129
#**********************************************
130130
pca10056.name=Bluefruit on PCA10056
131131

@@ -155,8 +155,8 @@ pca10056.menu.softdevice.s140v6.build.sd_name=s140
155155
pca10056.menu.softdevice.s140v6.build.sd_version=6.1.0
156156
pca10056.menu.softdevice.s140v6.build.sd_fwid=0x00AE
157157
pca10056.menu.softdevice.s140v6.build.ldscript=nrf52840_s140_v6.ld
158-
pca10056.menu.softdevice.s140v6.upload.maximum_size=303104
159-
pca10056.menu.softdevice.s140v6.upload.maximum_data_size=51072
158+
pca10056.menu.softdevice.s140v6.upload.maximum_size=552960
159+
pca10056.menu.softdevice.s140v6.upload.maximum_data_size=248832
160160

161161
# Debug Menu
162162
pca10056.menu.debug.l0=Level 0 (Release)

cores/nRF5/Print.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,12 @@ class Print
4545
void clearWriteError() { setWriteError(0); }
4646

4747
virtual size_t write(uint8_t) = 0;
48+
virtual size_t write(const uint8_t *buffer, size_t size);
49+
4850
size_t write(const char *str) {
4951
if (str == NULL) return 0;
5052
return write((const uint8_t *)str, strlen(str));
5153
}
52-
virtual size_t write(const uint8_t *buffer, size_t size);
5354
size_t write(const char *buffer, size_t size) {
5455
return write((const uint8_t *)buffer, size);
5556
}

cores/nRF5/usb/USBSerial.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ class USBSerial : public Stream
5757
virtual void flush(void);
5858
virtual size_t write(uint8_t);
5959
virtual size_t write(const uint8_t *buffer, size_t size);
60-
using Print::write; // pull in write(str) from Print
60+
size_t write(const char *buffer, size_t size) {
61+
return write((const uint8_t *)buffer, size);
62+
}
6163
operator bool();
6264

6365
size_t readBytes(char *buffer, size_t length);

cores/nRF5/utility/debug.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ void dbgDumpMemoryCFormat(const char* str, void const *buf, uint16_t count)
282282
#include "ble_hci.h"
283283

284284
/*------------------------------------------------------------------*/
285-
/* Event String
285+
/* BLE Event String
286286
*------------------------------------------------------------------*/
287287
static lookup_entry_t const _strevt_lookup[] =
288288
{

libraries/Bluefruit52Lib/src/bluefruit.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,7 @@ void adafruit_soc_task(void* arg)
801801
// Flash
802802
case NRF_EVT_FLASH_OPERATION_SUCCESS:
803803
case NRF_EVT_FLASH_OPERATION_ERROR:
804+
LOG_LV1("SOC", "NRF_EVT_FLASH_OPERATION_%s", soc_evt == NRF_EVT_FLASH_OPERATION_SUCCESS ? "SUCCESS" : "ERROR");
804805
if ( flash_nrf5x_event_cb ) flash_nrf5x_event_cb(soc_evt);
805806
break;
806807

libraries/FileSystem/src/FileIO.h

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,13 @@ class File: public Stream
5858

5959
virtual size_t write (uint8_t ch);
6060
virtual size_t write (uint8_t const *buf, size_t size);
61+
size_t write(const char *str) {
62+
if (str == NULL) return 0;
63+
return write((const uint8_t *)str, strlen(str));
64+
}
65+
size_t write(const char *buffer, size_t size) {
66+
return write((const uint8_t *)buffer, size);
67+
}
6168

6269
virtual int read (void);
6370
int read (void *buf, uint16_t nbyte);
@@ -79,8 +86,6 @@ class File: public Stream
7986
File openNextFile (uint8_t mode = FILE_READ);
8087
void rewindDirectory (void);
8188

82-
using Print::write;
83-
8489
private:
8590
FileSystemClass* _fs;
8691
void* _hdl;

0 commit comments

Comments
 (0)