fix more warnings

Author: hathach

libraries/BLEAdafruitService/src/services/BLEAdafruitSensor.h

@@ -44,8 +44,8 @@ class BLEAdafruitSensor : public BLEService
     void setNotifyCallback(notify_callback_t fp);
 
   protected:
-    BLECharacteristic _period;
     BLECharacteristic _measurement;
+    BLECharacteristic _period;
 
     Adafruit_Sensor*  _sensor;
 

libraries/Bluefruit52Lib/examples/Central/central_pairing/central_pairing.ino

@@ -310,6 +310,9 @@ void pairing_complete_callback(uint16_t conn_handle, uint8_t auth_status)
   }else
   {
     Serial.println("Failed");
+
+    // disconnect
+    conn->disconnect();
   }
 
 #ifdef USE_ARCADA
@@ -321,9 +324,6 @@ void pairing_complete_callback(uint16_t conn_handle, uint8_t auth_status)
   {
     tft->setTextColor(ARCADA_RED);
     tft->print("Failed ");
-
-    // disconnect
-    conn->disconnect();
   }
 
   tft->setTextColor(ARCADA_WHITE);

libraries/Bluefruit52Lib/examples/Peripheral/ancs_oled/ancs_oled.ino

@@ -241,7 +241,7 @@ void displayNotification(int index)
   }else
   {
     // Text size = 1, max char is 21. Text size = 2, max char is 10
-    char tempbuf[22];
+    char tempbuf[30];
     sprintf(tempbuf, "%-15s %02d/%02d", myNtf->app_name, index+1, notifCount);
 
     oled.println(tempbuf);

libraries/Bluefruit52Lib/examples/Peripheral/arduino_science_journal/arduino_science_journal.ino

@@ -84,7 +84,7 @@ void onPDMdata() {
 
 uint16_t getSoundAverage() {
   uint32_t avg = 0;
-  for (int i = 0; i < sizeof(soundSampleBuffer)/sizeof(soundSampleBuffer[0]); i++) {
+  for (uint32_t i = 0; i < sizeof(soundSampleBuffer)/sizeof(soundSampleBuffer[0]); i++) {
     avg += soundSampleBuffer[i]*soundSampleBuffer[i];
   }
   return sqrt(avg);

libraries/Bluefruit52Lib/examples/Peripheral/image_eink_transfer/image_eink_transfer.ino

@@ -207,6 +207,10 @@ void bleuart_rx_callback(uint16_t conn_hdl)
       red = (c565 & 0xf800) >> 8;
       green = (c565 & 0x07e0) >> 3;
       blue = (c565 & 0x001f) << 3;
+    }else
+    {
+      Serial.println("Error: incorrect color bits ");
+      while(1) yield();
     }
 
     // Convert RGB into Eink Color

libraries/SoftwareSerial/SoftwareSerial.h

@@ -59,7 +59,7 @@ class SoftwareSerial : public Stream
   static SoftwareSerial *active_object;
 
   // private methods
-  void recv() __attribute__((__always_inline__));
+  void recv();
   uint32_t rx_pin_read();
   void tx_pin_write(uint8_t pin_state) __attribute__((__always_inline__));
   void setTX(uint8_t transmitPin);