Skip to content

Commit 0149263

Browse files
committed
Use RGB red and blue as primary and secondary.
The code currently expects a primary LED no matter what so the RGB led support combined with that clobbers the nice pulsing primary.
1 parent 05726e2 commit 0149263

File tree

1 file changed

+7
-18
lines changed

1 file changed

+7
-18
lines changed

src/boards/mdk_nrf52840_dongle.h

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@
4242
/*------------------------------------------------------------------*/
4343
/* LED
4444
*------------------------------------------------------------------*/
45-
// TODO(gpshead): only an rgb led, not a separate primary one. 0?
46-
#define LEDS_NUMBER 1
47-
#define LED_PRIMARY_PIN _PINNUM(0, 23)
45+
#define LEDS_NUMBER 2 // TODO(gpshead): support 0.
46+
#define LED_PRIMARY_PIN _PINNUM(0, 23) // Red
47+
#define LED_SECONDARY_PIN _PINNUM(0, 24) // Blue
4848
#define LED_STATE_ON 0
4949

50-
#define LED_RGB_RED_PIN _PINNUM(0, 23)
51-
#define LED_RGB_GREEN_PIN _PINNUM(0, 22)
52-
#define LED_RGB_BLUE_PIN _PINNUM(0, 24)
53-
#define BOARD_RGB_BRIGHTNESS 0x202020
50+
//#define LED_RGB_RED_PIN _PINNUM(0, 23)
51+
//#define LED_RGB_GREEN_PIN _PINNUM(0, 22)
52+
//#define LED_RGB_BLUE_PIN _PINNUM(0, 24)
53+
#define BOARD_RGB_BRIGHTNESS 0x404040
5454
/*------------------------------------------------------------------*/
5555
/* BUTTON
5656
*------------------------------------------------------------------*/
@@ -60,17 +60,6 @@
6060
#define BUTTON_2 _PINNUM(0, 19) // no connection
6161
#define BUTTON_PULL NRF_GPIO_PIN_PULLUP
6262

63-
/*------------------------------------------------------------------*/
64-
/* UART
65-
* TODO(gpshead): Does this even make sense to define?
66-
* No serial pins. USB ACM/CDC only.
67-
*------------------------------------------------------------------*/
68-
#define RX_PIN_NUMBER 8
69-
#define TX_PIN_NUMBER 6
70-
#define CTS_PIN_NUMBER 0
71-
#define RTS_PIN_NUMBER 0
72-
#define HWFC false
73-
7463
// Used as model string in OTA mode
7564
#define DIS_MANUFACTURER "MakerDiary"
7665
#define DIS_MODEL "nRF52840 Micro Dev Kit USB Dongle"

0 commit comments

Comments
 (0)