Fix signed/unsigned bug.

henrygab · henrygab · commit 52cfdaa2d2c1 · 2019-03-12T13:05:21.000-07:00
diff --git a/src/usb/msc_uf2.c b/src/usb/msc_uf2.c
@@ -63,7 +63,7 @@ int write_block(uint32_t block_no, uint8_t *data, bool quiet, WriteState *state)
 int32_t tud_msc_scsi_cb (uint8_t lun, uint8_t const scsi_cmd[16], void* buffer, uint16_t bufsize)
 {
   void const* response = NULL;
-  uint16_t resplen = 0;
+  int32_t resplen = 0;
 
   switch ( scsi_cmd[0] )
   {
@@ -98,7 +98,7 @@ int32_t tud_msc_scsi_cb (uint8_t lun, uint8_t const scsi_cmd[16], void* buffer,
   }
 
   // return len must not larger than bufsize
-  if ( resplen > bufsize ) resplen = bufsize;
+  if ( resplen > (int32_t)bufsize ) resplen = bufsize;
 
   // copy response to stack's buffer if any
   if ( response && resplen )

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ int write_block(uint32_t block_no, uint8_t data, bool quiet, WriteState state)`
`63`	`63`	`int32_t tud_msc_scsi_cb (uint8_t lun, uint8_t const scsi_cmd[16], void* buffer, uint16_t bufsize)`
`64`	`64`	`{`
`65`	`65`	`void const* response = NULL;`
`66`		`- uint16_t resplen = 0;`
	`66`	`+ int32_t resplen = 0;`
`67`	`67`
`68`	`68`	`switch ( scsi_cmd[0] )`
`69`	`69`	`{`
`@@ -98,7 +98,7 @@ int32_t tud_msc_scsi_cb (uint8_t lun, uint8_t const scsi_cmd[16], void* buffer,`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`// return len must not larger than bufsize`
`101`		`- if ( resplen > bufsize ) resplen = bufsize;`
	`101`	`+ if ( resplen > (int32_t)bufsize ) resplen = bufsize;`
`102`	`102`
`103`	`103`	`// copy response to stack's buffer if any`
`104`	`104`	`if ( response && resplen )`