Skip to content

Commit 5c5b994

Browse files
committed
rename clean up
1 parent f99645e commit 5c5b994

File tree

1 file changed

+22
-20
lines changed

1 file changed

+22
-20
lines changed

Makefile

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,14 @@ SD_HEX = $(SD_PATH)/$(SD_FILENAME)_softdevice.hex
2222
# linker by MCU and SoftDevice eg. nrf52840_s140_v6.ld
2323
LD_FILE = linker/$(MCU_SUB_VARIANT)_$(SD_NAME)_v$(word 1, $(subst ., ,$(SD_VERSION))).ld
2424

25-
MERGED_FNAME = $(OUTPUT_FILENAME)_$(SD_NAME)_$(SD_VERSION)
26-
2725
GIT_VERSION = $(shell git describe --dirty --always --tags)
2826
GIT_SUBMODULE_VERSIONS = $(shell git submodule status | cut -d' ' -f3,4 | paste -s -d" " -)
2927

30-
OUTPUT_FILENAME = $(BOARD)_bootloader-$(GIT_VERSION)
28+
# compiled file name
29+
OUT_FILE = $(BOARD)_bootloader-$(GIT_VERSION)
30+
31+
# merged file = compiled + sd
32+
MERGED_FILE = $(OUT_FILE)_$(SD_NAME)_$(SD_VERSION)
3133

3234
#******************************************************************************
3335
# Tool configure
@@ -250,7 +252,7 @@ CFLAGS += -DMK_BOOTLOADER_VERSION='($(word 1,$(_VER)) << 16) + ($(word 2,$(_VER)
250252
#******************************************************************************
251253

252254
# keep every function in separate section. This will allow linker to dump unused functions
253-
LDFLAGS += -Xlinker -Map=$(BUILD)/$(OUTPUT_FILENAME).map
255+
LDFLAGS += -Xlinker -Map=$(BUILD)/$(OUT_FILE).map
254256
LDFLAGS += -mthumb -mabi=aapcs -Llinker -T$(LD_FILE)
255257
LDFLAGS += -mcpu=cortex-m4
256258
LDFLAGS += -mfloat-abi=hard -mfpu=fpv4-sp-d16
@@ -306,7 +308,7 @@ endif
306308
.phony: all clean size flash sd erase
307309

308310
# default target to build
309-
all: $(BUILD)/$(OUTPUT_FILENAME)-nosd.out size
311+
all: $(BUILD)/$(OUT_FILE)-nosd.out size
310312

311313
#******************* Flash target *******************
312314

@@ -318,11 +320,11 @@ __check_defined = \
318320
$(error Undefined make flag: $1$(if $2, ($2))))
319321

320322
# Flash the compiled
321-
flash: $(BUILD)/$(OUTPUT_FILENAME)-nosd.hex
323+
flash: $(BUILD)/$(OUT_FILE)-nosd.hex
322324
@echo Flashing: $<
323325
$(NRFJPROG) --program $< --sectoranduicrerase -f nrf52 --reset
324326

325-
dfu-flash: $(BUILD)/$(MERGED_FNAME).zip
327+
dfu-flash: $(BUILD)/$(MERGED_FILE).zip
326328
@:$(call check_defined, SERIAL, example: SERIAL=/dev/ttyACM0)
327329
$(NRFUTIL) --verbose dfu serial --package $< -p $(SERIAL) -b 115200 --singlebank --touch 1200
328330

@@ -334,11 +336,11 @@ erase:
334336
@echo Erasing chip
335337
$(NRFJPROG) --eraseall -f nrf52
336338

337-
gdbflash: $(BUILD)/$(MERGED_FNAME).hex
339+
gdbflash: $(BUILD)/$(MERGED_FILE).hex
338340
@echo Flashing: $<
339341
@$(GDB_BMP) -nx --batch -ex 'load $<' -ex 'compare-sections' -ex 'kill'
340342

341-
gdb: $(BUILD)/$(OUTPUT_FILENAME)-nosd.out
343+
gdb: $(BUILD)/$(OUT_FILE)-nosd.out
342344
$(GDB_BMP) $<
343345

344346
#******************* Compile rules *******************
@@ -361,11 +363,11 @@ $(BUILD)/%.o: %.S
361363
$(QUIET)$(CC) $(ASMFLAGS) $(INC_PATHS) -c -o $@ $<
362364

363365
# Link
364-
$(BUILD)/$(OUTPUT_FILENAME)-nosd.out: $(BUILD) $(OBJECTS)
365-
@echo LD $(OUTPUT_FILENAME)-nosd.out
366+
$(BUILD)/$(OUT_FILE)-nosd.out: $(BUILD) $(OBJECTS)
367+
@echo LD $(OUT_FILE)-nosd.out
366368
$(QUIET)$(CC) $(LDFLAGS) $(OBJECTS) $(LIBS) -lm -o $@
367369

368-
size: $(BUILD)/$(OUTPUT_FILENAME)-nosd.out
370+
size: $(BUILD)/$(OUT_FILE)-nosd.out
369371
-@echo ''
370372
$(QUIET)$(SIZE) $<
371373
-@echo ''
@@ -375,21 +377,21 @@ size: $(BUILD)/$(OUTPUT_FILENAME)-nosd.out
375377
.phony: genhex genpkg
376378

377379
## Create binary .hex file from the .out file
378-
genhex: $(BUILD)/$(OUTPUT_FILENAME)-nosd.hex
380+
genhex: $(BUILD)/$(OUT_FILE)-nosd.hex
379381

380-
$(BUILD)/$(OUTPUT_FILENAME)-nosd.hex: $(BUILD)/$(OUTPUT_FILENAME)-nosd.out
381-
@echo CR $(OUTPUT_FILENAME)-nosd.hex
382+
$(BUILD)/$(OUT_FILE)-nosd.hex: $(BUILD)/$(OUT_FILE)-nosd.out
383+
@echo CR $(OUT_FILE)-nosd.hex
382384
$(QUIET)$(OBJCOPY) -O ihex $< $@
383385

384386
# merge bootloader and sd hex together
385-
combinehex: $(BUILD)/$(MERGED_FNAME).hex
387+
combinehex: $(BUILD)/$(MERGED_FILE).hex
386388

387-
$(BUILD)/$(MERGED_FNAME).hex: $(BUILD)/$(OUTPUT_FILENAME)-nosd.hex
388-
@echo CR $(MERGED_FNAME).hex
389+
$(BUILD)/$(MERGED_FILE).hex: $(BUILD)/$(OUT_FILE)-nosd.hex
390+
@echo CR $(MERGED_FILE).hex
389391
@mergehex -q -m $< $(SD_HEX) -o $@
390392

391393
## Create pkg file for bootloader+SD combo to use with DFU
392-
genpkg: $(BUILD)/$(MERGED_FNAME).zip
394+
genpkg: $(BUILD)/$(MERGED_FILE).zip
393395

394-
$(BUILD)/$(MERGED_FNAME).zip: $(BUILD)/$(OUTPUT_FILENAME)-nosd.hex
396+
$(BUILD)/$(MERGED_FILE).zip: $(BUILD)/$(OUT_FILE)-nosd.hex
395397
@$(NRFUTIL) dfu genpkg --dev-type 0x0052 --dev-revision $(DFU_DEV_REV) --bootloader $< --softdevice $(SD_HEX) $@

0 commit comments

Comments
 (0)