Skip to content

Commit 9d86c6b

Browse files
committed
Replaced conditional recipes with function calls.
1 parent 5b507ac commit 9d86c6b

File tree

1 file changed

+13
-33
lines changed

1 file changed

+13
-33
lines changed

Makefile

Lines changed: 13 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,18 @@ GDB = $(CROSS_COMPILE)gdb
4848
NRFUTIL = adafruit-nrfutil
4949
NRFJPROG = nrfjprog
5050
FLASHER ?= nrfjprog
51+
PYOCD ?= pyocd
5152

5253
# Flasher will default to nrfjprog,
5354
# Check for pyocd, error on unexpected value.
54-
ifeq ($(FLASHER),pyocd)
55-
PYOCD ?= pyocd
55+
ifeq ($(FLASHER),nrfjprog)
56+
FLASH_CMD = $(NRFJPROG) --program $1 --sectoranduicrerase -f nrf52 --reset
57+
FLASH_NOUICR_CMD = $(NRFJPROG) --program $1 -f nrf52 --sectorerase --reset
58+
FLASH_ERASE_CMD = $(NRFJPROG) -f nrf52 --eraseall
59+
else ifeq ($(FLASHER),pyocd)
60+
FLASH_CMD = $(PYOCD) flash -t $(MCU_SUB_VARIANT) $1
61+
FLASH_NOUICR_CMD = $(PYOCD) flash -t $(MCU_SUB_VARIANT) $1
62+
FLASH_ERASE_CMD = $(PYOCD) erase -t $(MCU_SUB_VARIANT) --chip
5663
else
5764
$(error Unsupported flash utility: "$(FLASHER)")
5865
endif
@@ -397,51 +404,24 @@ __check_defined = \
397404
$(if $(value $1),, \
398405
$(error Undefined make flag: $1$(if $2, ($2))))
399406

400-
#------------------- Flash with NRFJPROG -------------------
401-
ifeq ($(FLASHER),nrfjprog)
402-
403407
# Flash the compiled
404408
flash: $(BUILD)/$(OUT_FILE)-nosd.hex
405409
@echo Flashing: $(notdir $<)
406-
$(NRFJPROG) --program $< --sectoranduicrerase -f nrf52 --reset
410+
$(call FLASH_CMD,$<)
407411

408412
erase:
409413
@echo Erasing flash
410-
$(NRFJPROG) -f nrf52 --eraseall
414+
$(call FLASH_ERASE_CMD)
411415

412416
# flash SD only
413417
sd:
414418
@echo Flashing: $(SD_HEX)
415-
$(NRFJPROG) --program $(SD_HEX) -f nrf52 --sectorerase --reset
419+
$(call FLASH_NOUICR_CMD,$(SD_HEX))
416420

417421
# flash MBR only
418422
mbr:
419423
@echo Flashing: $(MBR_HEX)
420-
$(NRFJPROG) --program $(MBR_HEX) -f nrf52 --sectorerase --reset
421-
422-
#------------------- Flash with PYOCD -------------------
423-
else ifeq ($(FLASHER),pyocd)
424-
425-
# Flash the compiled
426-
flash: $(BUILD)/$(OUT_FILE)-nosd.hex
427-
@echo Flashing: $(notdir $<)
428-
$(PYOCD) flash -t $(MCU_SUB_VARIANT) $<
429-
430-
erase:
431-
@echo Erasing flash
432-
$(PYOCD) erase -t $(MCU_SUB_VARIANT) --chip
433-
434-
# flash SD only
435-
sd:
436-
@echo Flashing: $(SD_HEX)
437-
$(PYOCD) flash -t $(MCU_SUB_VARIANT) $(SD_HEX)
438-
439-
# flash MBR only
440-
mbr:
441-
@echo Flashing: $(MBR_HEX)
442-
$(PYOCD) flash -t $(MCU_SUB_VARIANT) $(MBR_HEX)
443-
444-
endif
424+
$(call FLASH_NOUICR_CMD,$(MBR_HEX))
445425

446426
#------------------- Flash with NRFUTIL via DFU -------------------
447427

0 commit comments

Comments
 (0)