correct number of retry attempt

hathach · hathach · commit ace22e071c9a · 2025-02-27T17:08:16.000+07:00
diff --git a/src/pio_usb_host.c b/src/pio_usb_host.c
@@ -540,7 +540,7 @@ static int __no_inline_not_in_flash_func(usb_in_transaction)(pio_port_t *pp,
       res = -2;
     }
 
-    if (++ep->failed_count > TRANSACTION_MAX_RETRY) {
+    if (++ep->failed_count >= TRANSACTION_MAX_RETRY) {
       pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_ERROR_BITS); // failed after 3 consecutive retries
     }
   }
@@ -581,7 +581,7 @@ static int __no_inline_not_in_flash_func(usb_out_transaction)(pio_port_t *pp,
     pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_STALLED_BITS);
   } else {
     res = -1;
-    if (++ep->failed_count > TRANSACTION_MAX_RETRY) {
+    if (++ep->failed_count >= TRANSACTION_MAX_RETRY) {
       pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_ERROR_BITS);
     }
   }
@@ -621,7 +621,7 @@ static int __no_inline_not_in_flash_func(usb_setup_transaction)(
   } else {
     res = -1;
     ep->data_id = USB_PID_SETUP; // retry setup
-    if (++ep->failed_count > TRANSACTION_MAX_RETRY) {
+    if (++ep->failed_count >= TRANSACTION_MAX_RETRY) {
       pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_ERROR_BITS);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ static int __no_inline_not_in_flash_func(usb_in_transaction)(pio_port_t *pp,`
`540`	`540`	`res = -2;`
`541`	`541`	`}`
`542`	`542`
`543`		`- if (++ep->failed_count > TRANSACTION_MAX_RETRY) {`
	`543`	`+ if (++ep->failed_count >= TRANSACTION_MAX_RETRY) {`
`544`	`544`	`pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_ERROR_BITS); // failed after 3 consecutive retries`
`545`	`545`	`}`
`546`	`546`	`}`
`@@ -581,7 +581,7 @@ static int __no_inline_not_in_flash_func(usb_out_transaction)(pio_port_t *pp,`
`581`	`581`	`pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_STALLED_BITS);`
`582`	`582`	`} else {`
`583`	`583`	`res = -1;`
`584`		`- if (++ep->failed_count > TRANSACTION_MAX_RETRY) {`
	`584`	`+ if (++ep->failed_count >= TRANSACTION_MAX_RETRY) {`
`585`	`585`	`pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_ERROR_BITS);`
`586`	`586`	`}`
`587`	`587`	`}`
`@@ -621,7 +621,7 @@ static int __no_inline_not_in_flash_func(usb_setup_transaction)(`
`621`	`621`	`} else {`
`622`	`622`	`res = -1;`
`623`	`623`	`ep->data_id = USB_PID_SETUP; // retry setup`
`624`		`- if (++ep->failed_count > TRANSACTION_MAX_RETRY) {`
	`624`	`+ if (++ep->failed_count >= TRANSACTION_MAX_RETRY) {`
`625`	`625`	`pio_usb_ll_transfer_complete(ep, PIO_USB_INTS_ENDPOINT_ERROR_BITS);`
`626`	`626`	`}`
`627`	`627`	`}`