Handle rp2350 pio2 by using sdk pio_get_instance & PIO_IRQ_NUM #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
force-pushed
the
support-rp2350-pio2
branch
2 times, most recently
from
6fd9478 to
21b0b3e
Compare
jepler
force-pushed
the
support-rp2350-pio2
branch
from
21b0b3e to
7f7ea5b
Compare
|
Is this what is already in adafruit/circuitpython#9999 ? |
Author
|
Yes, that PR updated this submodule -- https://github.com/adafruit/circuitpython/pull/9999/files#diff-cc2914cdc1a964f5f4ab0029292a5c077f8a7052909583cebd21c1ca069fbd78 |
Author
|
hmmm it may not match... |
Author
dhalbert
approved these changes
Jan 28, 2025
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
great! Go ahead and submit a simple PR to update circuitpython to the merge commit here.
ladyada
pushed a commit
that referenced
this pull request
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, only pio0/1 was usable for USB Host.
I'll also PR this upstream.