Skip to content

Fix CI error from dvi.c #6

@BlitzCityDIY

Description

@BlitzCityDIY

An error began appearing via CI on the Learn repo with the PicoDVI arduino library in the dvi.c file:

Used library            Version Path
PicoDVI - Adafruit Fork 1.1.0   /home/runner/Arduino/libraries/PicoDVI_-_Adafruit_Fork
Adafruit GFX Library    1.11.10 /home/runner/Arduino/libraries/Adafruit_GFX_Library
Adafruit BusIO          1.16.1  /home/runner/Arduino/libraries/Adafruit_BusIO
Wire                    1.0     /home/runner/.arduino15/packages/rp2040/hardware/rp2040/4.0.1/libraries/Wire
SPI                     1.0     /home/runner/.arduino15/packages/rp2040/hardware/rp2040/4.0.1/libraries/SPI

Used platform Version Path
rp2040:rp2040 4.0.1   /home/runner/.arduino15/packages/rp2040/hardware/rp2040/4.0.1

/home/runner/Arduino/libraries/PicoDVI_-_Adafruit_Fork/src/libdvi/dvi.c: In function 'dvi_dma_irq_handler':
/home/runner/Arduino/libraries/PicoDVI_-_Adafruit_Fork/src/libdvi/dvi.c:194:68: error: 'dma_debug_channel_hw_t' has no member named 'tcr'
  194 |                 while (dma_debug_hw->ch[inst->dma_cfg[i].chan_data].tcr != inst->timing->h_active_pixels / DVI_SYMBOLS_PER_WORD)
      |                                                                    ^
/home/runner/Arduino/libraries/PicoDVI_-_Adafruit_Fork/src/libdvi/dvi.c:211:68: warning: comparison of integer expressions of different signedness: 'uint' {aka 'unsigned int'} and 'int' [-Wsign-compare]
  211 |                 if (inst->timing_state.v_ctr % dvi_vertical_repeat == dvi_vertical_repeat - 1) {
      |                                                                    ^~
/home/runner/Arduino/libraries/PicoDVI_-_Adafruit_Fork/src/libdvi/dvi.c:219:68: warning: comparison of integer expressions of different signedness: 'uint' {aka 'unsigned int'} and 'int' [-Wsign-compare]
  219 |                 if (inst->timing_state.v_ctr % dvi_vertical_repeat == dvi_vertical_repeat - 1)
      |                                                                    ^~
/home/runner/Arduino/libraries/PicoDVI_-_Adafruit_Fork/src/libdvi/dvi.c:232:103: warning: comparison of integer expressions of different signedness: 'uint' {aka 'unsigned int'} and 'int' [-Wsign-compare]
  232 |                         if (inst->scanline_callback && inst->timing_state.v_ctr % dvi_vertical_repeat == dvi_vertical_repeat - 1) {
      |                                                                                                       ^~

this is affecting all 3 PicoDVI projects on Learn. right now they have none.test.only files as a workaround, added in this PR: adafruit/Adafruit_Learning_System_Guides#2879

previously the error was treated as a warning: https://github.com/adafruit/Adafruit_Learning_System_Guides/actions/runs/10478095833/job/29020694693#step:7:455

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions