Add SSD1306 devices + Sh1107 #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brentru This is ready for review, and ties in with adafruit/Adafruit_Wippersnapper_Arduino#760 |
|
Keeping this open to match the first few comments on adafruit/Adafruit_Wippersnapper_Arduino#760 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some missing devices (the 128x32 featherwing can only be 0x3c) and default address ordering.
Also adds the SH1107 featherwing, and a 0.49" sized 64x32 display.
It's worth talking at some point about rotation. We could specify the screens default rotation in the definition file (featherwing is 90*CW) which would make sense once we add it to protobuf. For now there is a tiny bit of component specific logic in the core to set that rotation.