Skip to content

Commit 0a1842e

Browse files
authored
Merge pull request #8340 from jepler/qstr-dependency
Use QSTR_GLOBAL_REQUIREMENTS to give explicit dependency for qstr gen…
2 parents def7463 + b0967cb commit 0a1842e

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

ports/atmel-samd/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ OBJ += $(addprefix $(BUILD)/, $(SRC_CIRCUITPY_COMMON:.c=.o))
352352
OBJ += $(addprefix $(BUILD)/, $(SRC_S:.s=.o))
353353
OBJ += $(addprefix $(BUILD)/, $(SRC_MOD:.c=.o))
354354

355-
SRC_QSTR += $(HEADER_BUILD)/sdiodata.h
355+
QSTR_GLOBAL_REQUIREMENTS += $(HEADER_BUILD)/sdiodata.h
356356
OBJ_EXTRA_ORDER_DEPS += $(HEADER_BUILD)/sioddata.h
357357
$(HEADER_BUILD)/sdiodata.h: tools/mksdiodata.py | $(HEADER_BUILD)
358358
$(Q)$(PYTHON) $< > $@

ports/espressif/Makefile

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ endif
353353
# create the config headers
354354
.PHONY: do-sdkconfig
355355
do-sdkconfig: $(BUILD)/esp-idf/config/sdkconfig.h
356-
$(BUILD)/genhdr/qstr.i.last: $(BUILD)/esp-idf/config/sdkconfig.h
356+
QSTR_GLOBAL_REQUIREMENTS += $(BUILD)/esp-idf/config/sdkconfig.h
357357
$(BUILD)/esp-idf/config/sdkconfig.h: boards/$(BOARD)/sdkconfig CMakeLists.txt | $(BUILD)/esp-idf
358358
IDF_PATH=$(IDF_PATH) cmake -S . -B $(BUILD)/esp-idf -DSDKCONFIG=$(BUILD)/esp-idf/sdkconfig -DSDKCONFIG_DEFAULTS="$(SDKCONFIGS)" -DCMAKE_TOOLCHAIN_FILE=$(IDF_PATH)/tools/cmake/toolchain-$(IDF_TARGET).cmake -DIDF_TARGET=$(IDF_TARGET) -GNinja -DCIRCUITPY_ESPCAMERA=$(CIRCUITPY_ESPCAMERA)
359359

@@ -378,9 +378,6 @@ menuconfig: $(BUILD)/esp-idf/config $(BUILD)/esp-idf/config/sdkconfig.h
378378
# We should use that when available. For now, we sort out everything.
379379
python tools/update_sdkconfig.py --board=$(BOARD) --debug=$(DEBUG)
380380

381-
# qstr builds include headers so we need to make sure they are up to date
382-
$(HEADER_BUILD)/qstr.split: | $(BUILD)/esp-idf/config/sdkconfig.h
383-
384381
BINARY_WIFI_BLOBS = libcoexist.a libcore.a libespnow.a libmesh.a libnet80211.a libpp.a libsmartconfig.a libwapi.a
385382
BINARY_BLOBS = esp-idf/components/esp_phy/lib/$(IDF_TARGET)/libphy.a $(addprefix esp-idf/components/esp_wifi/lib/$(IDF_TARGET)/, $(BINARY_WIFI_BLOBS))
386383
ifeq ($(IDF_TARGET),esp32)

ports/raspberrypi/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,8 @@ $(BUILD)/stage2.c: stage2.c.jinja gen_stage2.py | $(BUILD)/
424424
$(STEPECHO) "GEN $<"
425425
$(Q)$(PYTHON) gen_stage2.py $< $@ $(EXTERNAL_FLASH_DEVICES)
426426

427-
$(HEADER_BUILD)/flash_info.h: flash_info.h.jinja gen_stage2.py | $(HEADER_BUILD)/
427+
QSTR_GLOBAL_REQUIREMENTS += $(HEADER_BUILD)/flash_info.h
428+
$(HEADER_BUILD)/flash_info.h: flash_info.h.jinja gen_stage2.py
428429
$(STEPECHO) "GEN $<"
429430
$(Q)$(PYTHON) gen_stage2.py $< $@ $(EXTERNAL_FLASH_DEVICES)
430431

0 commit comments

Comments
 (0)