Skip to content

Commit 0a58d45

Browse files
authored
Merge pull request #4306 from Neradoc/fix-reset-to-safe
press reset to safe mode on ports where reset reason is not implemented
2 parents e4f0e47 + 248acd0 commit 0a58d45

File tree

5 files changed

+3
-73
lines changed

5 files changed

+3
-73
lines changed

ports/atmel-samd/boards/feather_m0_express/mpconfigboard.mk

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,5 @@ CIRCUITPY_MSGPACK = 0
2020
CIRCUITPY_VECTORIO = 0
2121
CIRCUITPY_BUSDEVICE = 0
2222

23-
CFLAGS_INLINE_LIMIT = 60
2423
SUPEROPT_GC = 0
25-
26-
CFLAGS_BOARD = --param max-inline-insns-auto=15
27-
ifeq ($(TRANSLATION), ja)
28-
RELEASE_NEEDS_CLEAN_BUILD = 1
29-
CFLAGS_INLINE_LIMIT = 35
30-
endif
31-
ifeq ($(TRANSLATION), zh_Latn_pinyin)
32-
RELEASE_NEEDS_CLEAN_BUILD = 1
33-
CFLAGS_INLINE_LIMIT = 35
34-
endif
35-
ifeq ($(TRANSLATION), de_DE)
36-
RELEASE_NEEDS_CLEAN_BUILD = 1
37-
CFLAGS_INLINE_LIMIT = 35
3824
SUPEROPT_VM = 0
39-
endif

ports/atmel-samd/boards/metro_m0_express/mpconfigboard.mk

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,5 @@ CIRCUITPY_MSGPACK = 0
1919
CIRCUITPY_VECTORIO = 0
2020
CIRCUITPY_BUSDEVICE = 0
2121

22-
CFLAGS_INLINE_LIMIT = 60
2322
SUPEROPT_GC = 0
24-
25-
CFLAGS_BOARD = --param max-inline-insns-auto=15
26-
ifeq ($(TRANSLATION), ja)
27-
RELEASE_NEEDS_CLEAN_BUILD = 1
28-
CFLAGS_INLINE_LIMIT = 35
29-
endif
30-
ifeq ($(TRANSLATION), zh_Latn_pinyin)
31-
RELEASE_NEEDS_CLEAN_BUILD = 1
32-
CFLAGS_INLINE_LIMIT = 35
33-
endif
34-
ifeq ($(TRANSLATION), de_DE)
35-
RELEASE_NEEDS_CLEAN_BUILD = 1
36-
CFLAGS_INLINE_LIMIT = 35
3723
SUPEROPT_VM = 0
38-
endif

ports/atmel-samd/boards/stackrduino_m0_pro/mpconfigboard.mk

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -21,40 +21,5 @@ CIRCUITPY_MSGPACK = 0
2121
CIRCUITPY_VECTORIO = 0
2222
CIRCUITPY_BUSDEVICE = 0
2323

24-
CFLAGS_INLINE_LIMIT = 55
2524
SUPEROPT_GC = 0
26-
27-
CFLAGS_BOARD = --param max-inline-insns-auto=15
28-
ifeq ($(TRANSLATION), ja)
29-
RELEASE_NEEDS_CLEAN_BUILD = 1
30-
CFLAGS_INLINE_LIMIT = 35
31-
endif
32-
ifeq ($(TRANSLATION), zh_Latn_pinyin)
33-
RELEASE_NEEDS_CLEAN_BUILD = 1
34-
CFLAGS_INLINE_LIMIT = 35
35-
endif
36-
ifeq ($(TRANSLATION), de_DE)
37-
RELEASE_NEEDS_CLEAN_BUILD = 1
38-
CFLAGS_INLINE_LIMIT = 35
39-
SUPEROPT_VM = 0
40-
endif
41-
ifeq ($(TRANSLATION), pl)
42-
RELEASE_NEEDS_CLEAN_BUILD = 1
43-
CFLAGS_INLINE_LIMIT = 35
44-
SUPEROPT_VM = 0
45-
endif
46-
ifeq ($(TRANSLATION), fr)
47-
RELEASE_NEEDS_CLEAN_BUILD = 1
48-
CFLAGS_INLINE_LIMIT = 35
49-
SUPEROPT_VM = 0
50-
endif
51-
ifeq ($(TRANSLATION), pt_BR)
52-
RELEASE_NEEDS_CLEAN_BUILD = 1
53-
CFLAGS_INLINE_LIMIT = 35
54-
SUPEROPT_VM = 0
55-
endif
56-
ifeq ($(TRANSLATION), es)
57-
RELEASE_NEEDS_CLEAN_BUILD = 1
58-
CFLAGS_INLINE_LIMIT = 35
5925
SUPEROPT_VM = 0
60-
endif

ports/atmel-samd/boards/ugame10/mpconfigboard.mk

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,4 @@ FROZEN_MPY_DIRS += $(TOP)/frozen/circuitpython-stage/ugame10
3636

3737
CIRCUITPY_DISPLAY_FONT = $(TOP)/ports/atmel-samd/boards/ugame10/brutalist-6.bdf
3838

39-
# Tweak inlining depending on language.
40-
ifeq ($(TRANSLATION), zh_Latn_pinyin)
41-
RELEASE_NEEDS_CLEAN_BUILD = 1
42-
CFLAGS_INLINE_LIMIT = 45
43-
else
44-
CFLAGS_INLINE_LIMIT = 70
45-
endif
39+
SUPEROPT_GC = 0

supervisor/shared/safe_mode.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ safe_mode_t wait_for_safe_mode_reset(void) {
5959

6060
const mcu_reset_reason_t reset_reason = common_hal_mcu_processor_get_reset_reason();
6161
if (reset_reason != RESET_REASON_POWER_ON &&
62-
reset_reason != RESET_REASON_RESET_PIN) {
62+
reset_reason != RESET_REASON_RESET_PIN &&
63+
reset_reason != RESET_REASON_UNKNOWN) {
6364
return NO_SAFE_MODE;
6465
}
6566
port_set_saved_word(SAFE_MODE_DATA_GUARD | (MANUAL_SAFE_MODE << 8));

0 commit comments

Comments
 (0)